From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [lm-sensors] [PATCH 00/12] lis3 accelerator feature update Date: Sun, 24 Oct 2010 09:35:29 -0700 Message-ID: <20101024163529.GA14650@ericsson.com> References: <1287748654-2626-1-git-send-email-samu.p.onkalo@nokia.com> <4CC44B3D.5030404@tremplin-utc.net> <20101024153548.GA14303@ericsson.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20101024153548.GA14303-IzeFyvvaP7pWk0Htik3J/w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: =?iso-8859-1?Q?=C9ric?= Piel Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "lm-sensors-GZX6beZjE8VD60Wz+7aTrA@public.gmane.org" , "linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-i2c@vger.kernel.org On Sun, Oct 24, 2010 at 11:35:48AM -0400, Guenter Roeck wrote: > On Sun, Oct 24, 2010 at 11:05:33AM -0400, =C9ric Piel wrote: > > Op 22-10-10 13:57, Samu Onkalo schreef: > > > Changes are tested only with I2C interface using 8bit sensor sinc= e I don't > > > have other possibilities. Some features are not enabled > > > by default since I can't test them with all possible configuratio= ns. > > > Platform data contains field which controls new features. > > Thanks Samu for persevering with the automatic power down feature.=20 > > Hopefully I'll find also some time to activate it on the hp_accel s= ide. > >=20 > > For now, I've reviewed the changes and everything looked fine, as w= ell=20 > > as tested them on my HP laptop (with a 12 bits sensor). Although mo= st of=20 > > the changes are not visible on this platform, at least there should= n't=20 > > be any regression. > >=20 > Great, thanks. >=20 > Unfortunately, the patches don't apply to my staging branch, probably > because of the other pending lis3 changes. >=20 > Samu, please rebase your patches to=20 > git://git.kernel.org/pub/scm/linux/kernel/git/groeck/staging.git hwm= on-next > and resubmit. >=20 Never mind. Played a bit with git, learned something new, and got it al= l merged. Now compiling. Eric, once I pushed the changes into above branch (hopefully by tonight= ), would be great if you could give it another test run. Thanks, Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Sun, 24 Oct 2010 16:35:29 +0000 Subject: Re: [lm-sensors] [PATCH 00/12] lis3 accelerator feature update Message-Id: <20101024163529.GA14650@ericsson.com> List-Id: References: <1287748654-2626-1-git-send-email-samu.p.onkalo@nokia.com> <4CC44B3D.5030404@tremplin-utc.net> <20101024153548.GA14303@ericsson.com> In-Reply-To: <20101024153548.GA14303@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: =?iso-8859-1?Q?=C9ric?= Piel Cc: "linux-kernel@vger.kernel.org" , "lm-sensors@lm-sensors.org" , "linux-i2c@vger.kernel.org" On Sun, Oct 24, 2010 at 11:35:48AM -0400, Guenter Roeck wrote: > On Sun, Oct 24, 2010 at 11:05:33AM -0400, =C9ric Piel wrote: > > Op 22-10-10 13:57, Samu Onkalo schreef: > > > Changes are tested only with I2C interface using 8bit sensor since I = don't > > > have other possibilities. Some features are not enabled > > > by default since I can't test them with all possible configurations. > > > Platform data contains field which controls new features. > > Thanks Samu for persevering with the automatic power down feature.=20 > > Hopefully I'll find also some time to activate it on the hp_accel side. > >=20 > > For now, I've reviewed the changes and everything looked fine, as well = > > as tested them on my HP laptop (with a 12 bits sensor). Although most o= f=20 > > the changes are not visible on this platform, at least there shouldn't = > > be any regression. > >=20 > Great, thanks. >=20 > Unfortunately, the patches don't apply to my staging branch, probably > because of the other pending lis3 changes. >=20 > Samu, please rebase your patches to=20 > git://git.kernel.org/pub/scm/linux/kernel/git/groeck/staging.git hwmon-n= ext > and resubmit. >=20 Never mind. Played a bit with git, learned something new, and got it all me= rged. Now compiling. Eric, once I pushed the changes into above branch (hopefully by tonight), would be great if you could give it another test run. Thanks, Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758460Ab0JXQgD (ORCPT ); Sun, 24 Oct 2010 12:36:03 -0400 Received: from imr4.ericy.com ([198.24.6.8]:44528 "EHLO imr4.ericy.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752321Ab0JXQgB (ORCPT ); Sun, 24 Oct 2010 12:36:01 -0400 Date: Sun, 24 Oct 2010 09:35:29 -0700 From: Guenter Roeck To: =?iso-8859-1?Q?=C9ric?= Piel CC: "linux-kernel@vger.kernel.org" , "lm-sensors@lm-sensors.org" , "linux-i2c@vger.kernel.org" Subject: Re: [lm-sensors] [PATCH 00/12] lis3 accelerator feature update Message-ID: <20101024163529.GA14650@ericsson.com> References: <1287748654-2626-1-git-send-email-samu.p.onkalo@nokia.com> <4CC44B3D.5030404@tremplin-utc.net> <20101024153548.GA14303@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20101024153548.GA14303@ericsson.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 24, 2010 at 11:35:48AM -0400, Guenter Roeck wrote: > On Sun, Oct 24, 2010 at 11:05:33AM -0400, Éric Piel wrote: > > Op 22-10-10 13:57, Samu Onkalo schreef: > > > Changes are tested only with I2C interface using 8bit sensor since I don't > > > have other possibilities. Some features are not enabled > > > by default since I can't test them with all possible configurations. > > > Platform data contains field which controls new features. > > Thanks Samu for persevering with the automatic power down feature. > > Hopefully I'll find also some time to activate it on the hp_accel side. > > > > For now, I've reviewed the changes and everything looked fine, as well > > as tested them on my HP laptop (with a 12 bits sensor). Although most of > > the changes are not visible on this platform, at least there shouldn't > > be any regression. > > > Great, thanks. > > Unfortunately, the patches don't apply to my staging branch, probably > because of the other pending lis3 changes. > > Samu, please rebase your patches to > git://git.kernel.org/pub/scm/linux/kernel/git/groeck/staging.git hwmon-next > and resubmit. > Never mind. Played a bit with git, learned something new, and got it all merged. Now compiling. Eric, once I pushed the changes into above branch (hopefully by tonight), would be great if you could give it another test run. Thanks, Guenter