From: "Michael S. Tsirkin" <mst@redhat.com>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH RFC] pcie: clean up hot plug notification
Date: Mon, 25 Oct 2010 10:05:35 +0200 [thread overview]
Message-ID: <20101025080535.GA5454@redhat.com> (raw)
In-Reply-To: <20101025070426.GW31309@valinux.co.jp>
On Mon, Oct 25, 2010 at 04:04:26PM +0900, Isaku Yamahata wrote:
> On Mon, Oct 25, 2010 at 08:46:38AM +0200, Michael S. Tsirkin wrote:
> > On Mon, Oct 25, 2010 at 03:44:01PM +0900, Isaku Yamahata wrote:
> > > On Mon, Oct 25, 2010 at 07:49:41AM +0200, Michael S. Tsirkin wrote:
> > > > Simplify logic for hotplug notification, by tracking state of the
> > > > logical interrupt condition. We then simply use this variable to make
> > > > the interrupt decision, according to spec.
> > > >
> > > > API is made cleaner as we no longer force users to pass in
> > > > old slot control value.
> > >
> > > Thank you for looking into it.
> > > Some comments below.
> >
> > Thanks! Care fixing up the remaining issues?
> > I will fold the fixup in.
>
> Will do.
One other thing: I think when we validate data on load
need to take w1c mask into account, not just wmask.
> yamahata
next prev parent reply other threads:[~2010-10-25 8:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 5:49 [Qemu-devel] [PATCH RFC] pcie: clean up hot plug notification Michael S. Tsirkin
2010-10-25 6:08 ` [Qemu-devel] " Michael S. Tsirkin
2010-10-25 6:44 ` Isaku Yamahata
2010-10-25 6:46 ` Michael S. Tsirkin
2010-10-25 7:04 ` Isaku Yamahata
2010-10-25 8:05 ` Michael S. Tsirkin [this message]
2010-10-25 10:55 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101025080535.GA5454@redhat.com \
--to=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.