Re: [PATCH 6/7] iwlwifi: defer update power mode while scan

[Stanislaw Gruszka <sgruszka@redhat.com>]

Hi Wey

On Fri, Oct 22, 2010 at 08:33:57AM -0700, Guy, Wey-Yi wrote:
> On Fri, 2010-10-22 at 08:04 -0700, Stanislaw Gruszka wrote:
> > -int iwl_power_update_mode(struct iwl_priv *priv, bool force)
> > +static void iwl_power_build_cmd(struct iwl_priv *priv,
> > +				struct iwl_powertable_cmd *cmd)
> >  {
> > -	int ret = 0;
> >  	bool enabled = priv->hw->conf.flags & IEEE80211_CONF_PS;
> > -	bool update_chains;
> > -	struct iwl_powertable_cmd cmd;
> >  	int dtimper;
[snip]
> >  	if (priv->cfg->base_params->broken_powersave)
> > -		iwl_power_sleep_cam_cmd(priv, &cmd);
> > +		iwl_power_sleep_cam_cmd(priv, cmd);
> Is this right?

Yes, patch change "cmd" to be a pointer anywhere in this function.

Stanislaw