From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42392 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PAKop-0003l5-30 for qemu-devel@nongnu.org; Mon, 25 Oct 2010 07:02:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PAKon-0004AH-VU for qemu-devel@nongnu.org; Mon, 25 Oct 2010 07:02:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14027) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PAKon-0004AC-NC for qemu-devel@nongnu.org; Mon, 25 Oct 2010 07:02:21 -0400 Date: Mon, 25 Oct 2010 12:55:36 +0200 From: "Michael S. Tsirkin" Message-ID: <20101025105536.GA16526@redhat.com> References: <20101025054941.GA3223@redhat.com> <20101025064401.GU31309@valinux.co.jp> <20101025064638.GA4211@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101025064638.GA4211@redhat.com> Subject: [Qemu-devel] Re: [PATCH RFC] pcie: clean up hot plug notification List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Isaku Yamahata Cc: qemu-devel@nongnu.org On Mon, Oct 25, 2010 at 08:46:38AM +0200, Michael S. Tsirkin wrote: > > > --- a/hw/pcie.h > > > +++ b/hw/pcie.h > > > @@ -74,6 +74,11 @@ struct PCIExpressDevice { > > > * also initialize it when loaded as > > > * appropreately. > > > */ > > > + bool hpev_notified; /* Logical AND of conditions for hot plug event. > > > + Following 6.7.3.4: > > > + Software Notification of Hot-Plug Events, an interrupt > > > + is sent whenever the logical and of these conditions > > > + transitions from false to true. */ > > > }; > > > > This breaks save/load. > > Right. We'll need to restore this on load. > Take a subfunction of hotplug_event_notify > and put it in the appropriate _load function. Or just call the notify - worst case we get an extra msi interrupt ... Not sure whether this is required but this seems to be what we do in virtio-pci. Up to you really ... -- MST