From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sog-mx-4.v43.ch3.sourceforge.com ([172.29.43.194] helo=mx.sourceforge.net) by sfs-ml-2.v29.ch3.sourceforge.com with esmtp (Exim 4.69) (envelope-from ) id 1PASjz-0002li-Et for user-mode-linux-devel@lists.sourceforge.net; Mon, 25 Oct 2010 19:29:55 +0000 Received: from smtp1.linux-foundation.org ([140.211.169.13]) by sog-mx-4.v43.ch3.sourceforge.com with esmtps (TLSv1:AES256-SHA:256) (Exim 4.69) id 1PASjy-0000mC-11 for user-mode-linux-devel@lists.sourceforge.net; Mon, 25 Oct 2010 19:29:55 +0000 Date: Mon, 25 Oct 2010 12:29:36 -0700 From: Andrew Morton Message-Id: <20101025122936.56d0370f.akpm@linux-foundation.org> In-Reply-To: <1288020273-31161-1-git-send-email-richard@nod.at> References: <1288020273-31161-1-git-send-email-richard@nod.at> Mime-Version: 1.0 Subject: Re: [uml-devel] [PATCH] um: Fix IRQ flag handling naming List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Richard Weinberger Cc: user-mode-linux-devel@lists.sourceforge.net, jkosina@suse.cz, jdike@addtoit.com, linux-kernel@vger.kernel.org, dhowells@redhat.com, jan.kiszka@web.de, xiyou.wangcong@gmail.com On Mon, 25 Oct 2010 17:24:33 +0200 Richard Weinberger wrote: > Commit df9ee292 changed the IRQ flag handling naming scheme > and broke UML. > This patch brings the new scheme to UML and makes it work again. > Please always fully describe a bug when fixing it. Something more than "broke". In the case of compilation errors or warnings, that means quoting the compiler error output and, if necessary, the means of reproducing it (config, compiler version, etc). I did an allnoconfig uml build and saw this: In file included from /usr/src/25/arch/um/include/asm/fixmap.h:5, from /usr/src/25/arch/um/include/shared/um_uaccess.h:10, from /usr/src/25/arch/um/include/asm/uaccess.h:41, from /usr/src/25/arch/um/include/asm/thread_info.h:13, from include/linux/thread_info.h:56, from include/linux/preempt.h:9, from include/linux/spinlock.h:50, from include/linux/seqlock.h:29, from include/linux/time.h:8, from include/linux/stat.h:60, from include/linux/module.h:10, from init/main.c:13: /usr/src/25/arch/um/include/asm/system.h:11:1: warning: "local_save_flags" redefined which I shall assume is the error which this patch addresses. ------------------------------------------------------------------------------ Nokia and AT&T present the 2010 Calling All Innovators-North America contest Create new apps & games for the Nokia N8 for consumers in U.S. and Canada $10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store http://p.sf.net/sfu/nokia-dev2dev _______________________________________________ User-mode-linux-devel mailing list User-mode-linux-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759585Ab0JYTaT (ORCPT ); Mon, 25 Oct 2010 15:30:19 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:53206 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759523Ab0JYTaR (ORCPT ); Mon, 25 Oct 2010 15:30:17 -0400 Date: Mon, 25 Oct 2010 12:29:36 -0700 From: Andrew Morton To: Richard Weinberger Cc: linux-kernel@vger.kernel.org, jdike@addtoit.com, user-mode-linux-devel@lists.sourceforge.net, dhowells@redhat.com, jkosina@suse.cz, jan.kiszka@web.de, xiyou.wangcong@gmail.com Subject: Re: [PATCH] um: Fix IRQ flag handling naming Message-Id: <20101025122936.56d0370f.akpm@linux-foundation.org> In-Reply-To: <1288020273-31161-1-git-send-email-richard@nod.at> References: <1288020273-31161-1-git-send-email-richard@nod.at> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Oct 2010 17:24:33 +0200 Richard Weinberger wrote: > Commit df9ee292 changed the IRQ flag handling naming scheme > and broke UML. > This patch brings the new scheme to UML and makes it work again. > Please always fully describe a bug when fixing it. Something more than "broke". In the case of compilation errors or warnings, that means quoting the compiler error output and, if necessary, the means of reproducing it (config, compiler version, etc). I did an allnoconfig uml build and saw this: In file included from /usr/src/25/arch/um/include/asm/fixmap.h:5, from /usr/src/25/arch/um/include/shared/um_uaccess.h:10, from /usr/src/25/arch/um/include/asm/uaccess.h:41, from /usr/src/25/arch/um/include/asm/thread_info.h:13, from include/linux/thread_info.h:56, from include/linux/preempt.h:9, from include/linux/spinlock.h:50, from include/linux/seqlock.h:29, from include/linux/time.h:8, from include/linux/stat.h:60, from include/linux/module.h:10, from init/main.c:13: /usr/src/25/arch/um/include/asm/system.h:11:1: warning: "local_save_flags" redefined which I shall assume is the error which this patch addresses.