From: Jakub Narebski <jnareb@gmail.com>
To: Giuseppe Bilotta <giuseppe.bilotta@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCHv6 02/10] gitweb: git_get_heads_list accepts an optional list of refs.
Date: Mon, 25 Oct 2010 23:56:37 +0200 [thread overview]
Message-ID: <201010252356.37472.jnareb@gmail.com> (raw)
In-Reply-To: <1287917136-26103-3-git-send-email-giuseppe.bilotta@gmail.com>
On Sun, 24 Sep 2010, Giuseppe Bilotta wrote:
> sub git_get_heads_list {
> - my $limit = shift;
> + my ($limit, @classes) = @_;
> + unless (defined @classes) {
> + my $remote_heads = gitweb_check_feature('remote_heads');
> + @classes = ('heads', $remote_heads ? 'remotes' : ());
> + }
defined(@array) is deprecated at t/../gitweb/gitweb.perl line 3221.
Should be simply 'unless (@classes)', or 'unless (scalar @classes)' but
conditionals provide boolean context, which is scalar context.
I'm sorry about missing it earlier.
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2010-10-25 21:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-24 10:45 [PATCHv6 00/10] gitweb: remote_heads feature Giuseppe Bilotta
2010-10-24 10:45 ` [PATCHv6 01/10] gitweb: introduce " Giuseppe Bilotta
2010-10-24 10:45 ` [PATCHv6 02/10] gitweb: git_get_heads_list accepts an optional list of refs Giuseppe Bilotta
2010-10-25 21:56 ` Jakub Narebski [this message]
2010-10-26 16:30 ` Giuseppe Bilotta
2010-10-24 10:45 ` [PATCHv6 03/10] gitweb: separate heads and remotes lists Giuseppe Bilotta
2010-10-25 15:01 ` Jakub Narebski
2010-10-25 18:14 ` Giuseppe Bilotta
2010-10-24 10:45 ` [PATCHv6 04/10] gitweb: nagivation menu for tags, heads and remotes Giuseppe Bilotta
2010-10-24 10:45 ` [PATCHv6 05/10] gitweb: use fullname as hash_base in heads link Giuseppe Bilotta
2010-10-25 14:56 ` Jakub Narebski
2010-10-25 15:07 ` Giuseppe Bilotta
2010-10-24 10:45 ` [PATCHv6 06/10] gitweb: allow action specialization in page header Giuseppe Bilotta
2010-10-24 10:45 ` [PATCHv6 07/10] gitweb: remotes view for a single remote Giuseppe Bilotta
2010-10-25 15:12 ` Jakub Narebski
2010-10-25 18:18 ` Giuseppe Bilotta
2010-10-24 10:45 ` [PATCHv6 08/10] gitweb: refactor repository URL printing Giuseppe Bilotta
2010-10-24 10:45 ` [PATCHv6 09/10] gitweb: provide a routine to display (sub)sections Giuseppe Bilotta
2010-10-25 15:15 ` Jakub Narebski
2010-10-25 18:21 ` Giuseppe Bilotta
2010-10-24 10:45 ` [PATCHv6 10/10] gitweb: group remote heads by remote Giuseppe Bilotta
2010-10-27 0:32 ` Jakub Narebski
2010-10-27 8:07 ` Jakub Narebski
2010-11-02 10:49 ` Giuseppe Bilotta
2010-11-02 23:58 ` Jakub Narebski
2010-11-03 7:49 ` Giuseppe Bilotta
2010-11-04 10:41 ` Jakub Narebski
2010-11-08 8:28 ` Giuseppe Bilotta
2010-11-08 11:05 ` Jakub Narebski
2010-11-08 11:18 ` Giuseppe Bilotta
2010-11-08 13:41 ` Jakub Narebski
2010-10-27 12:38 ` Jakub Narebski
2010-10-25 18:38 ` [PATCHv6 00/10] gitweb: remote_heads feature Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201010252356.37472.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=giuseppe.bilotta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.