From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 25 Oct 2010 20:52:06 -0700 From: Guenter Roeck To: "Zhang, Sonic" CC: Jonathan Cameron , Mike Frysinger , "linux-iio@vger.kernel.org" , "device-drivers-devel@blackfin.uclinux.org" Subject: Re: [PATCH 12/14] staging: iio: adc: new driver for ADT7408 temperature sensors Message-ID: <20101026035206.GA20995@ericsson.com> References: <1287865757-1031-1-git-send-email-vapier@gentoo.org> <1287865757-1031-12-git-send-email-vapier@gentoo.org> <4CC4B8F8.7010005@cam.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" In-Reply-To: List-ID: On Mon, Oct 25, 2010 at 11:27:42PM -0400, Zhang, Sonic wrote: > > > >-----Original Message----- > >From: Jonathan Cameron [mailto:jic23@cam.ac.uk] > >Sent: Monday, October 25, 2010 6:54 AM > >To: Mike Frysinger > >Cc: linux-iio@vger.kernel.org; > >device-drivers-devel@blackfin.uclinux.org; Zhang, Sonic; Guenter Roeck > >Subject: Re: [PATCH 12/14] staging: iio: adc: new driver for > >ADT7408 temperature sensors > > > >On 10/23/10 21:29, Mike Frysinger wrote: > >> From: Sonic Zhang > >Here we enter new territory. This device is already supported > >in hwmon. Do we have a usecase that is not covered by that driver? > > > > I don't find a way to get event notification other than poll in hwmon framework. So, I move all temperature devic with interrupt available to IIO framework. > A much better approach, if such notifications are required and make sense, would be to add it to the hwmon framework. Rewriting drivers just to get notifications is not a solution. Besides, did you consider using kobject_uevent() ? The generic gpio driver uses that mechanism to create udev notifications on alarms. Guenter