All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: Lorenzo Colitti <lorenzo@google.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: addrconf: clear IPv6 addresses and routes when losing link
Date: Tue, 26 Oct 2010 08:28:32 -0700	[thread overview]
Message-ID: <20101026082832.4c5af2ef@nehalam> (raw)
In-Reply-To: <AANLkTinGpt=EQX3aXRaj5mEUMDNpyEapbs4VyOwgtN55@mail.gmail.com>

On Mon, 25 Oct 2010 22:44:03 -0700
Lorenzo Colitti <lorenzo@google.com> wrote:

> On Mon, Oct 25, 2010 at 9:38 PM, Stephen Hemminger
> <shemminger@vyatta.com> wrote:
> > This is incorrect. When link is lost, routes and address should not be
> > flushed. They should be marked as tentative and then go through DAD again
> > on the new network.
> 
> That won't help the case I am trying to fix, which is the case where
> the new link has a global prefix different than the old link. Marking
> the addresses as tentative will simply make them pass DAD and come
> back as soon as link comes back. But since they don't match the prefix
> that is assigned to the new link, they are unusable, because packets
> can't be routed back to them.

For IPv4 this is already handled by network manager.
Why couldn't the same apply to IPv6?

> > If you do it this way, you break routing protocols when link is brought
> > down and back up.
> 
> The only addresses and routes flushed in this way should be ones that
> aren't manually configured, i.e., the ones created by autoconf
> (addrconf.c:2720 onwards). These won't be used by routing protocols,
> except for link-local addresses. So I assume you're talking about
> link-local here.

Not sure, let me do test it.

> Link-local addresses are immediately recreated in a tentative state as
> soon as link comes back, because on NETDEV_UP addrconf_notify calls
> addrconf_dev_config. So, this patch only makes it so that they become
> tentative when link goes away and comes back. In that time, the router
> that temporarily loses link is unable to send packets for the brief
> period of time that the link is performing DAD, but if the router has
> lost link, it will also fail to send the packet while link is lost.
> What's the additional failure scenario? Will it help if I make it so
> that link-local addresses aren't touched at all?

Link-local works fine.

-- 

  reply	other threads:[~2010-10-26 15:28 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-26  2:08 [PATCH] ipv6: addrconf: clear IPv6 addresses and routes when losing link Lorenzo Colitti
2010-10-26  4:38 ` Stephen Hemminger
2010-10-26  5:44   ` Lorenzo Colitti
2010-10-26 15:28     ` Stephen Hemminger [this message]
2010-10-26 17:11       ` Lorenzo Colitti
2010-11-02  2:54       ` Dan Williams
2010-11-05  6:40         ` Lorenzo Colitti
2010-10-26 16:58     ` Brian Haley
2010-10-26 17:09       ` Lorenzo Colitti
2010-10-26 17:10       ` David Miller
2010-10-26 17:13         ` Lorenzo Colitti
2010-10-26 17:21           ` David Miller
2010-10-26 17:37             ` Lorenzo Colitti
2010-10-26 17:47               ` David Miller
2010-10-26 17:50                 ` Lorenzo Colitti
2010-10-26 17:55                   ` David Miller
2010-10-26 18:02                     ` Lorenzo Colitti
2010-10-26 18:21                       ` David Miller
2010-11-02  2:50                       ` Dan Williams
2010-10-26 18:17                 ` Lorenzo Colitti
2010-10-26 18:23                   ` David Miller
2010-10-26 22:53                     ` Lorenzo Colitti
2010-10-27 15:51                       ` David Miller
2010-10-27 16:01                         ` Lorenzo Colitti
2010-10-27 16:05                           ` David Miller
2010-10-27  2:31 ` Brian Haley
2010-10-27  8:35   ` Maciej Żenczykowski
2010-10-27 16:03     ` Lorenzo Colitti
2010-10-27 20:39       ` Maciej Żenczykowski
2010-10-28 22:23         ` Lorenzo Colitti
2010-10-28 22:41           ` Lorenzo Colitti
2010-10-28 22:50           ` Maciej Żenczykowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101026082832.4c5af2ef@nehalam \
    --to=shemminger@vyatta.com \
    --cc=lorenzo@google.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.