From mboxrd@z Thu Jan  1 00:00:00 1970
From: Alessandro Rubini <rubini-list@gnudd.com>
Date: Tue, 26 Oct 2010 21:54:29 +0200
Subject: [U-Boot] [PATCH 3/3 v2] Replace CONFIG_SYS_GBL_DATA_SIZE by
 auto-generated value
In-Reply-To: <1288104730-25651-1-git-send-email-wd@denx.de>
References: <1288104730-25651-1-git-send-email-wd@denx.de>
	<1288101601-24871-4-git-send-email-wd@denx.de>
Message-ID: <20101026195429.GA1349@morgana.i.gnudd.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

> +	/* Round up to make sure size gives nice stack alignment */
> +	DEFINE(GENERATED_GBL_DATA_SIZE,
> +		(sizeof(struct global_data)+15) & ~15);
> +

This has already been applied, sooner than usual.  Isn't it cleaner to
force alignment on the structure itself? This way different architectures
may use different values, if the need arises.

This shows it.

    struct a {
        int i;
    } __attribute__((aligned(16)));

    struct b {
        int i;
    };

    int main()
    {
        printf("%i %i\n", sizeof(struct a), sizeof(struct b));
    }

It prints "16 4" as expected.

/alessandro