From: Alessandro Rubini <rubini-list@gnudd.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3 v2] Replace CONFIG_SYS_GBL_DATA_SIZE by auto-generated value
Date: Tue, 26 Oct 2010 22:57:56 +0200 [thread overview]
Message-ID: <20101026205756.GA2139@morgana.i.gnudd.com> (raw)
In-Reply-To: <20101026203811.D0EF1152451@gemini.denx.de>
>> This has already been applied, sooner than usual. Isn't it cleaner to
>> force alignment on the structure itself? This way different architectures
>> may use different values, if the need arises.
>
> It would be better, but how to implement that?
Instead of:
DEFINE(GENERATED_GBL_DATA_SIZE,
(sizeof(struct global_data)+15) & ~15);
I'd use:
DEFINE(GENERATED_GBL_DATA_SIZE,
(sizeof(struct global_data)),
leaving the alignment requirement in the structure itself
(include/asm/global_data.h for each architecture).
/alessandro
next prev parent reply other threads:[~2010-10-26 20:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 13:59 [U-Boot] [PATCH 0/3] Introduce asm-offsets and fix CONFIG_SYS_GBL_DATA_SIZE problems Wolfgang Denk
2010-10-26 13:59 ` [U-Boot] [PATCH 1/3] Rename CONFIG_SYS_INIT_RAM_END into CONFIG_SYS_INIT_RAM_SIZE Wolfgang Denk
2010-10-26 19:02 ` Wolfgang Denk
2010-10-26 14:00 ` [U-Boot] [PATCH 2/3] include/asm-offsets.h: automatically generate assembler constants Wolfgang Denk
2010-10-26 14:11 ` Alexander Stein
2010-10-26 14:16 ` Wolfgang Denk
2010-10-26 14:19 ` [U-Boot] [PATCH 2/3 v2] " Wolfgang Denk
2010-10-26 19:04 ` Wolfgang Denk
2010-10-26 14:00 ` [U-Boot] [PATCH 3/3] Replace CONFIG_SYS_GBL_DATA_SIZE by auto-generated value Wolfgang Denk
2010-10-26 14:22 ` Stefan Roese
2010-10-26 14:32 ` Kumar Gala
2010-10-26 14:41 ` Wolfgang Denk
2010-10-26 15:22 ` Stefan Roese
2010-10-26 14:52 ` [U-Boot] [PATCH 3/3 v2] " Wolfgang Denk
2010-10-26 19:05 ` Wolfgang Denk
2010-10-26 19:54 ` Alessandro Rubini
2010-10-26 20:38 ` Wolfgang Denk
2010-10-26 20:57 ` Alessandro Rubini [this message]
2010-10-26 21:12 ` Wolfgang Denk
2010-10-26 21:18 ` Alessandro Rubini
2010-10-26 21:31 ` Wolfgang Denk
2010-10-26 21:40 ` Alessandro Rubini
2010-10-27 18:41 ` Wolfgang Denk
2010-10-26 15:17 ` [U-Boot] [PATCH 3/3] " Mike Frysinger
2010-10-26 16:42 ` Wolfgang Denk
2010-10-26 14:16 ` [U-Boot] [PATCH 0/3] Introduce asm-offsets and fix CONFIG_SYS_GBL_DATA_SIZE problems Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101026205756.GA2139@morgana.i.gnudd.com \
--to=rubini-list@gnudd.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.