From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 26 Oct 2010 23:45:10 +0200 Subject: [U-Boot] [PATCH] cmd_net: drop spurious comma in U_BOOT_CMD In-Reply-To: <20101026191510.5AC28152451@gemini.denx.de> References: <1287560010-31252-1-git-send-email-vapier@gentoo.org> <20101026191510.5AC28152451@gemini.denx.de> Message-ID: <20101026214510.7AB5F1365D8@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <20101026191510.5AC28152451@gemini.denx.de> I wrote: > Dear Mike Frysinger, > > In message <1287560010-31252-1-git-send-email-vapier@gentoo.org> you wrote: > > Building for boards that have CONFIG_CMD_CDP enabled fail with: > > cmd_net.c:301: error: expected expression before ',' token > > > > Signed-off-by: Mike Frysinger > > --- > > common/cmd_net.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > Applied, thanks. I wish I had tested this before applying - and even more I wish you had run MAKEALL as requested when sumbitting patches. Reverted, as it breaks building of some boards: Configuring for LANTEC board... cmd_net.c:301:1: error: macro "U_BOOT_CMD" requires 6 arguments, but only 5 given cmd_net.c:298: warning: data definition has no type or storage class cmd_net.c:298: warning: type defaults to 'int' in declaration of 'U_BOOT_CMD' make[1]: *** [/work/wd/tmp-ppc/common/cmd_net.o] Error 1 Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de Unsichtbar macht sich die Dummheit, indem sie immer gr??ere Ausma?e annimmt. -- Bertold Brecht: Der Tui-Roman