All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jon Dowland <jmtd@debian.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Matthew Garrett <mjg@redhat.com>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] toshiba_acpi.c: Add key_entry for a lone FN keypress
Date: Wed, 27 Oct 2010 00:24:59 +0100	[thread overview]
Message-ID: <20101026232459.GA1444@deckard.alcopop.org> (raw)
In-Reply-To: <20101026155653.GC13097@core.coreip.homeip.net>

On Tue, Oct 26, 2010 at 08:56:53AM -0700, Dmitry Torokhov wrote:
> > Add a key entry to map this event to a KEY_UNKNOWN keypress silences
> 
>                                          ^^^^^^
> Better fix commit log message as well. Otherwise:
> 
> 	Acked-by: Dmitry Torokhov <dtor@mail.ru>

Thanks.

Signed-off-by: Jon Dowland <jmtd@debian.org>

----

A lone FN key press on a Toshiba Portégé R700 without another key in
conjunction results in an ACPI event and a spurious error message on
the console.

Add a key entry to map this event to a KEY_FN keypress. This prevents
the console message.

diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c
index 06f304f..e10747a 100644
--- a/drivers/platform/x86/toshiba_acpi.c
+++ b/drivers/platform/x86/toshiba_acpi.c
@@ -135,6 +135,7 @@ static const struct key_entry toshiba_acpi_keymap[] __initconst = {
 	{ KE_KEY, 0x141, { KEY_BRIGHTNESSUP } },
 	{ KE_KEY, 0x142, { KEY_WLAN } },
 	{ KE_KEY, 0x143, { KEY_PROG1 } },
+	{ KE_KEY, 0x17f, { KEY_FN } },                                          
 	{ KE_KEY, 0xb05, { KEY_PROG2 } },
 	{ KE_KEY, 0xb06, { KEY_WWW } },
 	{ KE_KEY, 0xb07, { KEY_MAIL } },

  reply	other threads:[~2010-10-26 23:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-23 22:12 [PATCH] toshiba_acpi.c: Add key_entry for a lone FN keypress Jon Dowland
2010-10-25 18:27 ` Dmitry Torokhov
2010-10-25 18:42   ` Azael Avalos
2010-10-26 12:06     ` Jon Dowland
2010-10-26 12:00   ` Jon Dowland
2010-10-26 15:56     ` Dmitry Torokhov
2010-10-26 23:24       ` Jon Dowland [this message]
2010-11-24 16:48         ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101026232459.GA1444@deckard.alcopop.org \
    --to=jmtd@debian.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.