From: "Jan Stępień" <jan@stepien.cc>
To: Drew Northup <drew.northup@maine.edu>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fetch-pack: make the ssh connection quiet
Date: Wed, 27 Oct 2010 20:40:23 +0200 [thread overview]
Message-ID: <20101027204023.729808c8.jan@stepien.cc> (raw)
In-Reply-To: <1288193069.15518.40.camel@drew-northup.unet.maine.edu>
On Wed, 27 Oct 2010 11:24:29 -0400
Drew Northup <drew.northup@maine.edu> wrote:
> On Wed, 2010-10-27 at 16:27 +0200, Jan Stępień wrote:
> > The --quiet option passed to fetch-pack did not affect the ssh child
> > process. When an ssh server sent a motd it was displayed because the ssh
> > client wasn't launched with the -q option. This patch makes ssh run quietly
> > when fetch-pack is called with -q.
> >
> > An analogous change should be made to other commands which accept --quiet
> > and connect to remotes using ssh.
>
> I'm not so sure that's a good idea. Quoting from the (Open)SSH man page:
>
> -q Quiet mode. Causes all warning and diagnostic messages to be suppressed.
>
> Somehow I doubt that's what you intended or a good idea.
That's right, but according to the same source all fatal error messages
still get displayed. It's a question of how quiet should fetch-pack be
when --quiet is enabled.
Thanks for the comment,
--
Jan Stępień <jan@stepien.cc>
next prev parent reply other threads:[~2010-10-27 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 14:27 [PATCH] fetch-pack: make the ssh connection quiet Jan Stępień
2010-10-27 15:24 ` Drew Northup
2010-10-27 18:40 ` Jan Stępień [this message]
2010-10-27 22:35 ` Junio C Hamano
2010-10-28 9:14 ` Jan Stępień
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101027204023.729808c8.jan@stepien.cc \
--to=jan@stepien.cc \
--cc=drew.northup@maine.edu \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.