Re: [PATCH v2/RFC] Make git-completion Bash 4 compatible.

[Peter van der Does <peter@avirtualhome.com>]

On Thu, 28 Oct 2010 00:53:18 +0200
SZEDER Gábor <szeder@ira.uka.de> wrote:

> Hi Jonathan,
> 
> 
> On Wed, Oct 27, 2010 at 12:31:32PM -0500, Jonathan Nieder wrote:
> > Could some zsh user perhaps test that the new zsh support is not
> > broken?
> 
> I'm afraid it is.
> 
> The commit message of 06f44c3 (completion: make compatible with zsh,
> 2010-09-06) says:
> 
>     ${var:2}
>         Zsh does not implement ${var:2} to skip the first 2
> characters, but ${var#??} works in both shells to replace the first 2
> characters with nothing.  Thanks to Jonathan Nieder for the
> suggestion.
> 
>     for (( n=1; "$n" ... ))
>         Zsh does not allow "$var" in arithmetic loops.  Instead,
> pre-compute the endpoint and use the variables without $'s or quotes.
> 
> However, the functions taken over from the bash-completion code
> contain constructs like:
> 
>     ${cur:0:$index}
>     # ok, this is not exactly the same as ${var:2}, so it might even
>     # work...
> 
> and
> 
>     for (( i=0, j=0; i < ${#COMP_WORDS[@]}; i++, j++)); do
> 
> But I haven't actually tried it.
> 
> 
> Best,
> Gábor
> 
On the zsh change, I replied to the email "What's cooking in git.git
(Oct 2010, #02; Tue, 26)"

> With the patch "Make git-completion Bash 4 compatible" in mind, it
> might be useful to start looking into a different way to distribute
> the completion script to accommodate different shells. Adding
> compatibility for each shell into one script can get nasty. We could
> have a different completion script for each shell.

The bash completion script could still be included with the core, but
we can offer different versions for different shells.

-- 
Peter van der Does

GPG key: E77E8E98

IRC: Ganseki on irc.freenode.net
Twitter: @petervanderdoes