diff for duplicates of <20101027212253.GL6062@bicker> diff --git a/a/1.txt b/N1/1.txt index aa40add..02031c1 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -9,7 +9,7 @@ pointer". The dereference in find_writable_file() was added in The comments there say it's possible to trigger the NULL dereference under stress. -Signed-off-by: Dan Carpenter <error27@gmail.com> +Signed-off-by: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> diff --git a/fs/cifs/file.c b/fs/cifs/file.c index 06a006b..33a19b4 100644 @@ -21,7 +21,7 @@ index 06a006b..33a19b4 100644 cifs_sb = CIFS_SB(file->f_path.dentry->d_sb); - tcon = tlink_tcon(((struct cifsFileInfo *)file->private_data)->tlink); - if (file->private_data = NULL) { + if (file->private_data == NULL) { rc = -EBADF; FreeXid(xid); return rc; @@ -51,7 +51,7 @@ index 06a006b..33a19b4 100644 file->f_path.dentry->d_name.name, datasync); rc = filemap_write_and_wait(inode->i_mapping); -- if (rc = 0) { +- if (rc == 0) { - rc = CIFS_I(inode)->write_behind_rc; - CIFS_I(inode)->write_behind_rc = 0; - tcon = tlink_tcon(smbfile->tlink); diff --git a/a/content_digest b/N1/content_digest index 19c92a7..608e809 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,6 +1,6 @@ - "From\0Dan Carpenter <error27@gmail.com>\0" + "From\0Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" "Subject\0[patch 2/2] cifs: dereferencing first then checking\0" - "Date\0Wed, 27 Oct 2010 21:22:53 +0000\0" + "Date\0Wed, 27 Oct 2010 23:22:53 +0200\0" "To\0Steve French <sfrench-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org>\0" "Cc\0linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" samba-technical-w/Ol4Ecudpl8XjKLYN78aQ@public.gmane.org @@ -18,7 +18,7 @@ "The comments there say it's possible to trigger the NULL dereference\n" "under stress.\n" "\n" - "Signed-off-by: Dan Carpenter <error27@gmail.com>\n" + "Signed-off-by: Dan Carpenter <error27-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\n" "\n" "diff --git a/fs/cifs/file.c b/fs/cifs/file.c\n" "index 06a006b..33a19b4 100644\n" @@ -30,7 +30,7 @@ " \tcifs_sb = CIFS_SB(file->f_path.dentry->d_sb);\n" "-\ttcon = tlink_tcon(((struct cifsFileInfo *)file->private_data)->tlink);\n" " \n" - " \tif (file->private_data = NULL) {\n" + " \tif (file->private_data == NULL) {\n" " \t\trc = -EBADF;\n" " \t\tFreeXid(xid);\n" " \t\treturn rc;\n" @@ -60,7 +60,7 @@ " \t\tfile->f_path.dentry->d_name.name, datasync);\n" " \n" " \trc = filemap_write_and_wait(inode->i_mapping);\n" - "-\tif (rc = 0) {\n" + "-\tif (rc == 0) {\n" "-\t\trc = CIFS_I(inode)->write_behind_rc;\n" "-\t\tCIFS_I(inode)->write_behind_rc = 0;\n" "-\t\ttcon = tlink_tcon(smbfile->tlink);\n" @@ -92,4 +92,4 @@ " \treturn rc;\n" } -3536d8da19676414e3d54a7e82a7ed8306ee05b2c97ff6eab9efa10c8a30da3d +9741a3ad7b6918a01f2fc1d59d4f8e6ba50068206ff89d92028ae6af8427142a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.