All of lore.kernel.org
 help / color / mirror / Atom feed
From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Mark Lodato <lodatom@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] completion: fix zsh check under bash with 'set -u'
Date: Thu, 28 Oct 2010 15:51:54 +0200	[thread overview]
Message-ID: <20101028135154.GC1877@neumann> (raw)
In-Reply-To: <1288228101-23000-1-git-send-email-lodatom@gmail.com>

Hi Mark,


On Wed, Oct 27, 2010 at 09:08:21PM -0400, Mark Lodato wrote:
> Commit 06f44c3 (completion: make compatible with zsh) broke bash
> compatibility with 'set -u': a warning was generated when checking
> $ZSH_VERSION.  The solution is to supply a default value, using
> ${ZSH_VERSION-}.  Thanks to SZEDER Gábor for the fix.
> 
> Signed-off-by: Mark Lodato <lodatom@gmail.com>
> ---
>  contrib/completion/git-completion.bash |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)

Thanks.  It works with bash and set -u, so if it works with zsh as
well, then I'm for it.


While you are around, could you please have a look at this thread?

http://thread.gmane.org/gmane.comp.version-control.git/160103/focus=160135


Thanks,
Gábor

      reply	other threads:[~2010-10-28 13:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-28  1:08 [PATCH] completion: fix zsh check under bash with 'set -u' Mark Lodato
2010-10-28 13:51 ` SZEDER Gábor [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101028135154.GC1877@neumann \
    --to=szeder@ira.uka.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=lodatom@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.