Re: [PATCH] cacaoh: patches to get do_install do its work

[Stefan Schmidt <stefan@datenfreihafen.org>]

Hello.

On Tue, 2010-10-26 at 11:01, Enrico Scholz wrote:
> Khem Raj <raj.khem@gmail.com> writes:
> 
> >>>>> -    install -m 0755 src/cacaoh/.libs/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
> >>>>> +    install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}
> >>
> >> * libtool creates sometimes a wrapper script for executables (e.g. when
> >>   they are linked against local libraries) and places the real executable
> >>   in .libs/.  Manually installing one of them is error prone and it might
> >>   break with other linker flags or libtool versions.
> >
> > the binary in .libs do not exist so the link is final in this case.
> 
> Really?  The author of the original recipe had an environment where the
> executable was in .libs/.  Are you really sure that such an environment
> does not exist anymore? Or will the recipe now silently fail by installing
> the shell wrapper sometimes?

For me it did silently fail. :)

The openjdk-6 build failed due to missing header files like
 exceptions.c:44:45: error: native/include/java_lang_String.h: No such file or directory

> > but in any case If you can come up with a patch to install it using
> > libtool that would be nice.
> 
> Sorry; providing a patch means testing it (regardless whether it is
> trivial).  Here, I am not sure whether 'libtool' or the platform
> prefixed '<arch>-libtool' is required and how to express
> '<arch>-libtool' in oe.
> 
> I gave my comment to a patch which fixed a broken recipe by replacing it
> with another broken recipe.  So I expect that the author of this patch
> fixes and tests his work.
> 
> For completeness; install command should be
> 
> | libtool --mode=install install -m 0755 src/cacaoh/cacaoh ${STAGING_BINDIR}/cacaoh-cldc-${PV}

Thanks. I implemented this and the build works fine again. Thanks for letting us
know. Will push it in when I have network connectivity again.

regards
Stefan Schmidt