From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [patch 32/36 v2] hwmon: (w83795) Move register
Date: Thu, 28 Oct 2010 15:29:12 +0000 [thread overview]
Message-ID: <20101028152912.GC4311@ericsson.com> (raw)
In-Reply-To: <20101028164757.4011d335@endymion.delvare>
On Thu, Oct 28, 2010 at 10:47:57AM -0400, Jean Delvare wrote:
> Move initial register reads out of probe, to dedicated functions.
> This makes the code clearer, and will be needed if we want to delay
> calling these functions until they are needed, or want to call them
> periodically.
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
Still not sure about the scope of lsb across loop iterations, but I have not been able
to create a failure case, nor did I find clear indication if is guaranteed (or not)
that its value will be kept across loop iterations. But since gcc doesn't complain,
I should not complain either without real evidence of wrongdoing ;).
Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2010-10-28 15:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 14:47 [lm-sensors] [patch 32/36 v2] hwmon: (w83795) Move register reads Jean Delvare
2010-10-28 15:29 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101028152912.GC4311@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.