All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jim Rees <rees@umich.edu>
To: Steve Dickson <SteveD@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfs-utils: Check for strlcat/cpy and compile our private version only if it's needed.
Date: Thu, 28 Oct 2010 11:59:15 -0400	[thread overview]
Message-ID: <20101028155915.GA1685@merit.edu> (raw)
In-Reply-To: <4CC97D4C.1030007@RedHat.com>

Steve Dickson wrote:

  On 10/21/2010 08:01 AM, Jim Rees wrote:
  > Christoph Hellwig wrote:
  > 
  >   Not that I'd complain, but what Linux libc provides strlcat/cpy?
  > 
  > None that I know of.  The patch seems like a good idea to me, but it does
  > add a couple of ugly ifdefs to the include file.
  > 
  > There are already quite a few much sillier checks in configure.ac, like
  > memset, socket, and mkdir.
  > 
  > But I won't object if you want to drop this patch.
  I think if/when there is a need for these checks we
  can add them in then... Why add to the ugliness
  if we don't need to?  

Fine with me.  I was feeling guilty because I think I'm the one who
originally put the strlcat/cpy calls in, way back when idmapd did run on
non-linux platforms.

      reply	other threads:[~2010-10-28 15:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-20 21:35 [PATCH] nfs-utils: Check for strlcat/cpy and compile our private version only if it's needed Jim Rees
     [not found] ` <20101020213554.GA27541-8f4Pc2RrbJmHXe+LvDLADg@public.gmane.org>
2010-10-21  2:14   ` Christoph Hellwig
2010-10-21 12:01     ` Jim Rees
2010-10-21 12:40       ` Christoph Hellwig
2010-10-28 13:40       ` Steve Dickson
2010-10-28 15:59         ` Jim Rees [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101028155915.GA1685@merit.edu \
    --to=rees@umich.edu \
    --cc=SteveD@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.