From: David Miller <davem@davemloft.net>
To: dm@chelsio.com
Cc: leedom@chelsio.com, netdev@vger.kernel.org
Subject: Re: [PATCH] cxgb4vf: fix crash due to manipulating queues before registration
Date: Fri, 29 Oct 2010 13:05:59 -0700 (PDT) [thread overview]
Message-ID: <20101029.130559.112585228.davem@davemloft.net> (raw)
In-Reply-To: <8A71B368A89016469F72CD08050AD334088DA49E@maui.asicdesigners.com>
From: "Dimitrios Michailidis" <dm@chelsio.com>
Date: Fri, 29 Oct 2010 00:36:22 -0700
> Further, I believe moving the call after register_netdev is buggy as
> open can be called after registration and it can clash with the
> queue stopping. It seems then that these netif_tx_stop_all_queues
> calls have to go now.
This is a good explanation of why no driver should be touching the
queue state before the first ->open() call.
next prev parent reply other threads:[~2010-10-29 20:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-28 20:16 [PATCH] cxgb4vf: fix crash due to manipulating queues before registration Casey Leedom
2010-10-28 20:21 ` David Miller
2010-10-28 21:16 ` Casey Leedom
2010-10-29 7:36 ` Dimitrios Michailidis
2010-10-29 20:05 ` David Miller [this message]
2010-11-01 21:02 ` Divy Le Ray
2010-11-01 21:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101029.130559.112585228.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dm@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.