All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "David Kågedal" <davidk@lysator.liu.se>,
	"Sergei Organov" <osv@javad.com>,
	"Andreas Schwab" <schwab@linux-m68k.org>,
	git@vger.kernel.org, "Kevin Ryde" <user42@zip.com.au>
Subject: [PATCH resend] git-blame.el: Add (require 'format-spec)
Date: Thu, 28 Oct 2010 22:38:09 -0500	[thread overview]
Message-ID: <20101029033809.GA30353@burratino> (raw)
In-Reply-To: <87r5l0gkpc.fsf_-_@krank.kagedal.org>

Date: Tue, 25 May 2010 15:44:15 +0200
From: David Kågedal <davidk@lysator.liu.se>

c5022f57 (git-blame.el: Change how blame information is shown,
2009-09-29) taught the "M-x git-blame" mode to format its output
in a more interesting way, making use of the format-spec function.

format-spec is included in Emacs 23 and is a useful function.
Older emacsen can get it from Gnus.  In all emacsen, we need
to 'require it before use to avoid warnings:

 git-blame.el:483:1:Warning: the function `format-spec' is not known to be
     defined.

Reported-by: Sergei Organov <osv@javad.com>
Reported-by: Kevin Ryde <user42@zip.com.au>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
David Kågedal wrote:
>> On Sun, Dec 6, 2009 at 8:43 PM, David Kågedal <davidk@lysator.liu.se> wrote:
>>> Sergei Organov <osv@javad.com> writes:
>>>> Then there should be (require 'format-spec) in git-blame.el, right? Due
>>>> to:
>>>
>>> Of course. I must have missed that since I already had it loaded.
[...]
>                     here is the patch.

Junio, I think something like this patch is needed for git-blame.el
to work correctly.  I am no emacs lisp expert, though...

Other observations from that thread are a bit more worrying --- it
seems that c5022f57 dropped support for information about the selected
commit in the editor buffer, without updating the documentation in
contrib/emacs/README to match.

 contrib/emacs/git-blame.el |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/contrib/emacs/git-blame.el b/contrib/emacs/git-blame.el
index 7f4c792..d351cfb 100644
--- a/contrib/emacs/git-blame.el
+++ b/contrib/emacs/git-blame.el
@@ -79,6 +79,7 @@
 ;;; Code:
 
 (eval-when-compile (require 'cl))			      ; to use `push', `pop'
+(require 'format-spec)
 
 (defface git-blame-prefix-face
   '((((background dark)) (:foreground "gray"
-- 
1.7.0.4

  reply	other threads:[~2010-10-29  3:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04 16:21 git-blame.el: what is format-spec? Sergei Organov
2009-12-04 16:38 ` Andreas Schwab
2009-12-04 16:59   ` Sergei Organov
2009-12-04 17:36     ` David Kågedal
2009-12-04 20:54       ` Sergei Organov
2009-12-06 18:43         ` David Kågedal
2009-12-07  8:36           ` Sergei Organov
2009-12-07  9:05             ` David Kågedal
2010-05-14 13:13           ` Alex Unleashed
2010-05-25 13:44             ` [PATCH] git-blame.el: Add (require 'format-spec) David Kågedal
2010-10-29  3:38               ` Jonathan Nieder [this message]
2011-02-04  1:43           ` git-blame.el: does not show one-line summary in echo area Jonathan Nieder
2011-02-04  9:53             ` David Kågedal
2011-02-04 10:03               ` Jakub Narebski
2011-02-04 10:15                 ` David Kågedal
2011-02-04 12:26                   ` David Kågedal
2011-02-11  2:29                     ` Jonathan Nieder
2011-02-11  6:42                       ` git-blame.el: format of date strings Jonathan Nieder
2011-02-11  7:56                         ` Martin Nordholts
2012-06-10  8:24                       ` [PATCH/RFC] git-blame.el: truncate author to avoid jagged left edge of code Jonathan Nieder
2013-01-29 20:17                         ` David Kågedal
2011-02-04 21:49                   ` git-blame.el: does not show one-line summary in echo area Kevin Ryde
2009-12-04 17:42     ` git-blame.el: what is format-spec? Andreas Schwab
2009-12-04 18:18       ` Matthieu Moy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101029033809.GA30353@burratino \
    --to=jrnieder@gmail.com \
    --cc=davidk@lysator.liu.se \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=osv@javad.com \
    --cc=schwab@linux-m68k.org \
    --cc=user42@zip.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.