From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pasi =?iso-8859-1?Q?K=E4rkk=E4inen?= Subject: Re: [PATCH V3 0/6] firmware changes as part of QEMU/Xen merge. Date: Fri, 29 Oct 2010 16:27:42 +0300 Message-ID: <20101029132742.GO2804@reaktio.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: anthony.perard@citrix.com, Xen Devel List-Id: xen-devel@lists.xenproject.org On Fri, Oct 29, 2010 at 02:18:29PM +0100, Keir Fraser wrote: > On 29/10/2010 14:16, "Keir Fraser" wrote: > > >> Should it be called something else than HVM_PARAM_ACPI_NEW_IOPORT ? > >> After a couple of years "NEW" might not make much sense anymore.. > >> > >> IOPORT_V2 ? Or something.. > > > > I've asked for a nice big explanatory comment to be added beside the > > parameter's definition. Also we should treat this field as a version number, > > so baking a fixed version into its name is not a good idea. With the > > explanatory comment, I think its existing name is good enough. To do much > > better the name would have to become cumbersomely long. > > That said, HVM_PARAM_ACPI_IOPORTS_LOCATION might be better... I'm not > personally that fussed either way however. > Yeah, that sounds good.. -- Pasi