All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Par-Gunnar Hjalmdahl <pghatwork@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linus.walleij@stericsson.com, linux-bluetooth@vger.kernel.org,
	linux-kernel@vger.kernel.org, Lukasz.Rymanowski@tieto.com
Subject: Re: [PATCH 5/9] mfd: Add UART support for the ST-Ericsson CG2900.
Date: Fri, 29 Oct 2010 17:22:14 +0100	[thread overview]
Message-ID: <20101029172214.25b14c2a@pyx> (raw)
In-Reply-To: <AANLkTinh3D8V8UaN8FyCouwUQ98A4RRWEHXU7Tr9XMbs@mail.gmail.com>

> > Shouldn't you instead be using the drivers/bluetooth/hci_{ldisc,h4} code?
> 
> We also need the ldisc code to handle events from FM and GPS and since
> that is chip specific we cannot add that to the generic hci_ldisc
> code.

Agreed - it's a different protocol.

> I agree that we might run into problems if two drivers try to register
> the same line discipline. It might then be better to introduce a new

If your ldisc is written properly it shouldn't matter. Each tty has a
private ldisc pointer to keep the per ldisc instance data.

> line discipline then even though that could cause other problems. I do
> not know if it is possible to add a condition in Kconfig otherwise so
> the CG2900 ldisc cannot be active while the "normal" ldisc driver is
> selected.

Not sure I follow the concern here ?

  parent reply	other threads:[~2010-10-29 16:22 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-22 10:38 [PATCH 5/9] mfd: Add UART support for the ST-Ericsson CG2900 Par-Gunnar Hjalmdahl
2010-10-22 12:51 ` Alan Cox
2010-10-22 14:54   ` Par-Gunnar Hjalmdahl
2010-10-22 15:33     ` Alan Cox
2010-10-28 10:37       ` Par-Gunnar Hjalmdahl
2010-10-28 12:22     ` Arnd Bergmann
2010-10-29 11:58       ` Par-Gunnar Hjalmdahl
2010-10-29 12:08         ` Par-Gunnar Hjalmdahl
2010-10-30  0:09           ` Arnd Bergmann
2010-10-29 16:22         ` Alan Cox [this message]
2010-10-30  0:01           ` Arnd Bergmann
2010-10-31 12:04             ` Alan Cox
2010-11-05 17:02               ` Par-Gunnar Hjalmdahl
2010-11-05 17:19                 ` Alan Cox
2010-11-08  5:24                 ` Arnd Bergmann
2010-11-11 14:28                   ` Par-Gunnar Hjalmdahl
2010-11-11 14:40                     ` Par-Gunnar Hjalmdahl
2010-11-11 15:12                       ` Arnd Bergmann
2010-10-29 11:53   ` Par-Gunnar Hjalmdahl
2010-10-29 16:24     ` Alan Cox
2010-12-03  9:16       ` Par-Gunnar Hjalmdahl
2010-12-03 11:42         ` Vitaly Wool
2010-12-03 11:42           ` Vitaly Wool
2010-12-06  9:06           ` Par-Gunnar Hjalmdahl
2010-12-06  9:06             ` Par-Gunnar Hjalmdahl
2010-12-06  9:46             ` Vitaly Wool
2010-12-06 12:01               ` Par-Gunnar Hjalmdahl
2010-12-06 12:01                 ` Par-Gunnar Hjalmdahl
2010-12-06 12:25                 ` Vitaly Wool
2010-12-06 14:49                   ` Arnd Bergmann
2010-12-06 14:57                     ` Vitaly Wool
2010-12-06 14:06               ` Arnd Bergmann
2010-12-06 14:54                 ` Vitaly Wool
2010-12-06 15:15                   ` Arnd Bergmann
2010-12-06 15:28                     ` Vitaly Wool
2010-12-06 16:54                       ` Arnd Bergmann
2010-12-06 21:24                         ` Vitaly Wool
2010-12-06 23:07                           ` Arnd Bergmann
2010-12-08  7:41                             ` Pavan Savoy
2010-12-08  7:41                               ` Pavan Savoy
2010-12-08 12:21                               ` Par-Gunnar Hjalmdahl
2010-12-08 12:21                                 ` Par-Gunnar Hjalmdahl
2010-12-08 12:51                                 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101029172214.25b14c2a@pyx \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=Lukasz.Rymanowski@tieto.com \
    --cc=arnd@arndb.de \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pghatwork@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.