Re: [git:v4l-dvb/v2.6.37] [media] radio-si4713: Add regulator framework support

[Jarkko Nikula <jhnikula@gmail.com>]

On Fri, 29 Oct 2010 11:54:34 -0200
Mauro Carvalho Chehab <mchehab@redhat.com> wrote:

> I had to remove it from my queue, as the patch broke compilation:
> 
> 	http://git.linuxtv.org/media_tree.git?a=commit;h=350df81ebaccc651fa4dfad27738db958e067ded
> 
> What's the sense of adding a patch that breaks a driver?
> 
> Even assuming that you would later send a patch fixing it, there are still some problems:
> 
> 1) A latter patch will break git bisect;
> 2) A broken driver means that I can't test anymore if there are any other problems on other
>    drivers.
> 
> So, please test your patches against breakages, before sending them to me.
> 
Oh shit, true, my fault. I definitely forgot one file from git commit
but luckily I had the diff file around that I used in testing instead
of the commit I sent...

Sorry the hassle and thanks for letting me know, I'll send an update
in a minute.


-- 
Jarkko