From: Mike Snitzer <snitzer@redhat.com>
To: lvm-devel@redhat.com
Subject: Patch for fsadm bz 64146
Date: Fri, 29 Oct 2010 16:44:56 -0400 [thread overview]
Message-ID: <20101029204456.GB26687@redhat.com> (raw)
In-Reply-To: <4CCB2668.8020809@redhat.com>
On Fri, Oct 29 2010 at 3:54pm -0400,
Zdenek Kabelac <zkabelac@redhat.com> wrote:
> This patch address problem from BZ 64146.
>
> Instead of leaving lvresize to fail when running on the mounted fs (user
> expects online resize to happen and it's currently possible only with -n
> option) - this patch changes 'fsadm check' behavior so it returns success for
> mounted filesystem. This allows lvresize to processed further and run the
> online resize even without passing -n option.
>
> Anyone sees this modified behavior of fsadm script as a problem ?
> (change success for mounted fs).
>
> Zdenek
> Index: scripts/fsadm.sh
> ===================================================================
> RCS file: /cvs/lvm2/LVM2/scripts/fsadm.sh,v
> retrieving revision 1.20
> diff -u -p -r1.20 fsadm.sh
> --- scripts/fsadm.sh 8 Oct 2010 15:02:05 -0000 1.20
> +++ scripts/fsadm.sh 29 Oct 2010 19:43:33 -0000
> @@ -365,7 +365,10 @@ resize() {
> ###################
> check() {
> detect_fs "$1"
> - detect_mounted && error "Cannot fsck device \"$VOLUME\", filesystem is mounted on $MOUNTED"
> + if detect_mounted ; then
> + verbose "Skipping fsck device \"$VOLUME\" as filesystem is mounted on $MOUNTED";
I think the verbose message should be:
"Skipping fsck for device \"$VOLUME\" as filesystem is mounted on $MOUNTED"
Mike
next prev parent reply other threads:[~2010-10-29 20:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 19:54 Patch for fsadm bz 64146 Zdenek Kabelac
2010-10-29 19:56 ` Zdenek Kabelac
2010-10-29 19:59 ` Alasdair G Kergon
2010-10-29 20:44 ` Mike Snitzer [this message]
2010-10-29 20:56 ` Mike Snitzer
2010-10-29 21:26 ` Alasdair G Kergon
2010-10-30 16:44 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101029204456.GB26687@redhat.com \
--to=snitzer@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.