From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sukadev Bhattiprolu Subject: Re: [PATCH] pidns: Fix wait for zombies to be reaped in zap_pid_ns_processes Date: Sat, 30 Oct 2010 00:07:33 -0700 Message-ID: <20101030070733.GA21401@us.ibm.com> References: <20100709121425.GB18586@hawkmoon.kerlabs.com> <20100709141324.GC18586@hawkmoon.kerlabs.com> <20100711141406.GD18586@hawkmoon.kerlabs.com> <20100713214234.GA21042@hawkmoon.kerlabs.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Eric W. Biederman" Cc: Linux Containers , Andrew Morton , Pavel Emelyanov , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Oleg Nesterov List-Id: containers.vger.kernel.org Eric W. Biederman [ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org] wrote: | Louis Rilling writes: | | > This patch looks like it is working (only a small RCU issue shown below). I | > couldn't try it yet though. | | It certainly worked in my testing. | | > I must admit that I am using a similar back-off solution in Kerrighed (not to | > solve the issue of proc_flush_task(), but for one of the reasons that you stated | > above: we want to be sure that all tasks of the namespace have been reaped), but | > I considered it too ugly to propose it for Linux ;) | | Well sometimes you have to go with what works. | | Thanks for spotting those issue with my patch. I guess it needs one more | pass before I can call it done. Eric, Do you plan to resend this patch ? FYI, we ran into the problem that Louis Rilling reported when testing with the checkpoint/restart code and this patch fixes the problem (after a minor tweak to the C/R code). Thanks, Sukadev From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752090Ab0J3HAE (ORCPT ); Sat, 30 Oct 2010 03:00:04 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:55542 "EHLO e4.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808Ab0J3HAB (ORCPT ); Sat, 30 Oct 2010 03:00:01 -0400 Date: Sat, 30 Oct 2010 00:07:33 -0700 From: Sukadev Bhattiprolu To: "Eric W. Biederman" Cc: Andrew Morton , Linux Containers , linux-kernel@vger.kernel.org, Oleg Nesterov , Pavel Emelyanov Subject: Re: [PATCH] pidns: Fix wait for zombies to be reaped in zap_pid_ns_processes Message-ID: <20101030070733.GA21401@us.ibm.com> References: <20100709121425.GB18586@hawkmoon.kerlabs.com> <20100709141324.GC18586@hawkmoon.kerlabs.com> <20100711141406.GD18586@hawkmoon.kerlabs.com> <20100713214234.GA21042@hawkmoon.kerlabs.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eric W. Biederman [ebiederm@xmission.com] wrote: | Louis Rilling writes: | | > This patch looks like it is working (only a small RCU issue shown below). I | > couldn't try it yet though. | | It certainly worked in my testing. | | > I must admit that I am using a similar back-off solution in Kerrighed (not to | > solve the issue of proc_flush_task(), but for one of the reasons that you stated | > above: we want to be sure that all tasks of the namespace have been reaped), but | > I considered it too ugly to propose it for Linux ;) | | Well sometimes you have to go with what works. | | Thanks for spotting those issue with my patch. I guess it needs one more | pass before I can call it done. Eric, Do you plan to resend this patch ? FYI, we ran into the problem that Louis Rilling reported when testing with the checkpoint/restart code and this patch fixes the problem (after a minor tweak to the C/R code). Thanks, Sukadev