From: "Guo-Fu Tseng" <cooldavid@cooldavid.org>
To: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] jme: fix panic on load
Date: Mon, 1 Nov 2010 00:39:14 +0800 [thread overview]
Message-ID: <20101031163428.M61655@cooldavid.org> (raw)
In-Reply-To: <1288539978.2660.47.camel@edumazet-laptop>
On Sun, 31 Oct 2010 16:46:18 +0100, Eric Dumazet wrote
> Its now illegal to call netif_stop_queue() before register_netdev()
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Cc: Guo-Fu Tseng <cooldavid@cooldavid.org>
> ---
> drivers/net/jme.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/jme.c b/drivers/net/jme.c
> index d85edf3..c57d9a4 100644
> --- a/drivers/net/jme.c
> +++ b/drivers/net/jme.c
> @@ -2955,11 +2955,7 @@ jme_init_one(struct pci_dev *pdev,
> * Tell stack that we are not ready to work until open()
> */
> netif_carrier_off(netdev);
> - netif_stop_queue(netdev);
>
> - /*
> - * Register netdev
> - */
> rc = register_netdev(netdev);
> if (rc) {
> pr_err("Cannot register net device\n");
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Can this patch be modified to move the netif_stop_queue()
after register_netdev() ?
It seems the __QUEUE_STATE_XOFF is not set after the register_netdev.
The tx_queue was kcalloc() ed without touching state flags.
Guo-Fu Tseng
next prev parent reply other threads:[~2010-10-31 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-31 15:46 [PATCH] jme: fix panic on load Eric Dumazet
2010-10-31 16:34 ` David Miller
2010-10-31 16:39 ` Guo-Fu Tseng [this message]
2010-10-31 16:26 ` David Miller
2010-11-01 11:22 ` Guo-Fu Tseng
2010-10-31 16:32 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101031163428.M61655@cooldavid.org \
--to=cooldavid@cooldavid.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.