From: ynezz@true.cz (Petr Štetiar)
To: linux-arm-kernel@lists.infradead.org
Subject: ep93xx/ts72xx: Kernel 2.6.36 problems introduced with commit 5bc23d32d
Date: Sun, 31 Oct 2010 23:30:36 +0100 [thread overview]
Message-ID: <20101031223036.GB15069@ibawizard.net> (raw)
In-Reply-To: <20101031205210.GB30636@n2100.arm.linux.org.uk>
Russell King - ARM Linux <linux@arm.linux.org.uk> [2010-10-31 20:52:10]:
> It's being a little too over-cautious. In arch/arm/mm/dma-mapping.c
> __dma_alloc_remap, remove the + 1 from "bit = fls(size - 1) + 1;".
Hm, that was really fast :-) It works now, thank you!
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index 4bc43e5..7012105 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -198,7 +198,7 @@ __dma_alloc_remap(struct page *page, size_t size, gfp_t
gfp, pgprot_t prot)
* fragmentation of the DMA space, and also prevents allocations
* smaller than a section from crossing a section boundary.
*/
- bit = fls(size - 1) + 1;
+ bit = fls(size - 1);
if (bit > SECTION_SHIFT)
bit = SECTION_SHIFT;
align = 1 << bit;
-- ynezz
prev parent reply other threads:[~2010-10-31 22:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-31 18:21 ep93xx/ts72xx: Kernel 2.6.36 problems introduced with commit 5bc23d32d Petr Štetiar
2010-10-31 18:31 ` Russell King - ARM Linux
2010-10-31 19:00 ` Petr Štetiar
2010-10-31 19:08 ` Petr Štetiar
2010-10-31 20:52 ` Russell King - ARM Linux
2010-10-31 22:30 ` Petr Štetiar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101031223036.GB15069@ibawizard.net \
--to=ynezz@true.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.