From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jarkko Nikula <jhnikula@gmail.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH 2/2] ASoC: tlv320aic3x: Add support to shared common reset line
Date: Mon, 1 Nov 2010 09:08:04 -0400 [thread overview]
Message-ID: <20101101130804.GB22639@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1288613036-13169-2-git-send-email-jhnikula@gmail.com>
On Mon, Nov 01, 2010 at 02:03:56PM +0200, Jarkko Nikula wrote:
> This is aimed to configurations where multiple aic3x codecs share the same
> reset line and are powered from same supply voltages.
>
> Currently aic3x_probe will fail if trying to request already requested
> gpio_reset and passing -1 to another aic3x instances cause that those
> instances cannot release reset in aic3x_set_power. That is, another
> instances can work only if primary aic3x instance is powered and reset is
> released.
>
> Solve this by implementing a list of probed instances that is used for
> checking if other instance shares the same gpio_reset number. If a shared
> reset line exists, then only first instance tries to request and configure
> it and the last instance releases it.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
next prev parent reply other threads:[~2010-11-01 13:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-01 12:03 [PATCH 1/2] ASoC: tlv320aic3x: Use gpio_is_valid in checking for valid gpio_reset Jarkko Nikula
2010-11-01 12:03 ` [PATCH 2/2] ASoC: tlv320aic3x: Add support to shared common reset line Jarkko Nikula
2010-11-01 13:08 ` Mark Brown [this message]
2010-11-01 13:07 ` [PATCH 1/2] ASoC: tlv320aic3x: Use gpio_is_valid in checking for valid gpio_reset Mark Brown
2010-11-03 14:21 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101101130804.GB22639@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jhnikula@gmail.com \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.