All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Stezenbach <js@sig21.net>
To: Helmut Schaa <helmut.schaa@googlemail.com>
Cc: Lee <lee-in-berlin@web.de>,
	Gertjan van Wingerde <gwingerde@gmail.com>,
	linux-wireless@vger.kernel.org, Ivo van Doorn <ivdoorn@gmail.com>
Subject: Re: [regression]AP with hostapd 0.7.3 can't receive packets beyond authentication (2.6.36, rt73usb)
Date: Tue, 2 Nov 2010 13:50:07 +0100	[thread overview]
Message-ID: <20101102125007.GA30000@sig21.net> (raw)
In-Reply-To: <201010301430.15868.helmut.schaa@googlemail.com>

Hi,

On Sat, Oct 30, 2010 at 02:30:15PM +0200, Helmut Schaa wrote:
> Am Freitag 29 Oktober 2010 schrieb Lee:
> > On 29/10/10 00:17, Helmut Schaa wrote:
> > > In commit f1aa4c541e98afa8b770a75ccaa8504d0bff44a7 "rt2x00: Write the BSSID
> > > to register when interface is added" we've added the bssid passing to the
> > > device in AP mode to fix hw crypto on rt2800 devices in AP mode. But maybe
> > > the older devices behave differently and don't like getting a bssid set
> > > in AP mode?
> > >
> > > Lee, if you just revert the commit you've identified are you able to use
> > > the device in AP mode with hw crypto?
> > >
> > Reverting that memcpy() to it's original parameters works for me (AP mode + hw 
> > crypto).
> 
> Thanks for the info Lee. So, in AP mode we need to set the bssid on rt2800
> devices in order to get hw crypto to work but on (at least) rt73 devices we
> may not set the bssid to get hw crypto to work :(
> 
> Ivo, Gertjan, any ideas how to handle that case. I don't feel like introducing
> another device specific flag makes sense here?

Sorry for slow response time.  I can confirm that changing
		rt2x00lib_config_intf(rt2x00dev, intf, vif->type,
				      intf->mac, intf->bssid);
to
		rt2x00lib_config_intf(rt2x00dev, intf, vif->type,
				      intf->mac, NULL);
in rt2x00mac_add_interface() fixes rt73usb AP mode for me, too.
(still using compat-wireless-2.6.36-rc3-1)


While reading through the code I noticed the following in rt2800_config_intf():

		rt2x00_set_field32(&reg, MAC_BSSID_DW1_BSS_ID_MASK, 3);

However, in Ralink source from http://www.ralinktech.com/support.php?s=2
in DPO_RT3370_LinuxSTA_V2.4.0.1_20100831/include/chip/rtmp_mac.h it says:
                USHORT          BssIdMask:2; // 0: one BSSID, 10: 4 BSSID,  01: 2 BSSID , 11: 8BSSID

This is different from rt73usb where 3 means "one BSSID".
I have not tested this change yet.


Johannes

  reply	other threads:[~2010-11-02 12:50 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-21 23:47 [regression]AP with hostapd 0.7.3 can't receive packets beyond authentication (2.6.36-, rt73usb) Lee
2010-10-23 19:58 ` [regression]AP with hostapd 0.7.3 can't receive packets beyond authentication (2.6.36, rt73usb) Lee
2010-10-25 17:49   ` John W. Linville
2010-10-26  2:04     ` Lee
2010-10-26  5:40   ` Helmut Schaa
2010-10-26 10:19     ` Johannes Stezenbach
2010-10-26 11:03     ` Johannes Stezenbach
2010-10-26 15:40       ` Johannes Stezenbach
2010-10-28  8:16     ` Lee
2010-10-28  8:20       ` Ivo Van Doorn
2010-10-28  8:23       ` Helmut Schaa
2010-10-28 19:06         ` Lee
2010-10-28 19:54           ` Gertjan van Wingerde
2010-10-28 20:36             ` Ivo Van Doorn
2010-10-28 20:40               ` Gertjan van Wingerde
2010-10-28 22:17             ` Helmut Schaa
2010-10-29 21:39               ` Lee
2010-10-30 12:30                 ` Helmut Schaa
2010-11-02 12:50                   ` Johannes Stezenbach [this message]
2010-11-02 14:46                     ` Johannes Stezenbach
2010-11-02 14:58                       ` Ivo Van Doorn
2010-11-02 15:05                         ` Helmut Schaa
2010-11-02 15:49                           ` Johannes Stezenbach
2010-11-03 14:14                     ` Johannes Stezenbach
2010-11-03 14:50                       ` Ivo Van Doorn
2010-11-03 15:08                         ` Johannes Stezenbach
2010-11-03 14:51                       ` Ivo Van Doorn
2010-11-03 14:59                         ` Johannes Stezenbach
2010-11-03 15:21                           ` Helmut Schaa
2010-11-03 14:53                       ` Helmut Schaa
2010-10-29 16:17             ` Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101102125007.GA30000@sig21.net \
    --to=js@sig21.net \
    --cc=gwingerde@gmail.com \
    --cc=helmut.schaa@googlemail.com \
    --cc=ivdoorn@gmail.com \
    --cc=lee-in-berlin@web.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.