From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl>
Cc: Jarkko Nikula <jhnikula@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@nokia.com>,
Liam Girdwood <lrg@slimlogic.co.uk>,
Paul Walmsley <paul@pwsan.com>,
alsa-devel@alsa-project.org,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
e3-hacking@earth.li
Subject: Re: [PATCH 2.6.37-rc1] ASoC: OMAP: fix OMAP1 compilation problem
Date: Tue, 2 Nov 2010 10:56:18 -0400 [thread overview]
Message-ID: <20101102145617.GK21476@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201011021550.34885.jkrzyszt@tis.icnet.pl>
On Tue, Nov 02, 2010 at 03:50:32PM +0100, Janusz Krzysztofik wrote:
> In the new code introduced with commit cf4c87abe238ec17cd0255b4e21abd949d7f811e,
> "OMAP: McBSP: implement McBSP CLKR and FSR signal muxing via mach-omap2/mcbsp.c",
> the way omap1 build is supposed to bypass omap2 specific functionality doesn't
> optimize out all omap2 specific stuff. This breaks linking phase for omap1
> machines, giving "undefined reference to `omap2_mcbsp1_mux_clkr_src'"
> and "undefined reference to `omap2_mcbsp1_mux_fsr_src'" errors. Fix it.
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> case OMAP_MCBSP_CLKR_SRC_CLKR:
> + if (cpu_class_is_omap1())
> + break;
> omap2_mcbsp1_mux_clkr_src(CLKR_SRC_CLKR);
I guess this will still fail with optimisation diabled, but I'm not sure
anyone ever builds the kernel like that.
next prev parent reply other threads:[~2010-11-02 14:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 14:50 [PATCH 2.6.37-rc1] ASoC: OMAP: fix OMAP1 compilation problem Janusz Krzysztofik
2010-11-02 14:56 ` Mark Brown [this message]
2010-11-02 16:58 ` Paul Walmsley
2010-11-03 8:20 ` Jarkko Nikula
2010-11-03 14:16 ` [alsa-devel] " Liam Girdwood
2010-11-23 0:48 ` Paul Walmsley
2010-11-23 7:26 ` Jarkko Nikula
2010-11-23 10:32 ` [alsa-devel] " Liam Girdwood
2010-11-24 23:35 ` Tony Lindgren
2010-11-24 23:53 ` Tony Lindgren
2010-11-25 7:02 ` Jarkko Nikula
2010-11-25 12:47 ` Janusz Krzysztofik
2010-11-25 17:45 ` Paul Walmsley
2010-11-23 0:50 ` Paul Walmsley
2010-11-23 0:50 ` Paul Walmsley
2010-11-23 7:38 ` Jarkko Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101102145617.GK21476@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=e3-hacking@earth.li \
--cc=jhnikula@gmail.com \
--cc=jkrzyszt@tis.icnet.pl \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=paul@pwsan.com \
--cc=peter.ujfalusi@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.