From: Christoph Hellwig <hch@lst.de>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Daniel Stodden <daniel.stodden@citrix.com>,
Xen-devel <xen-devel@lists.xensource.com>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Subject: Re: [PATCH 4/4] xen/blkfront: cope with backend that fail empty BLKIF_OP_WRITE_BARRIER requests
Date: Tue, 2 Nov 2010 17:54:34 +0100 [thread overview]
Message-ID: <20101102165434.GA19703@lst.de> (raw)
In-Reply-To: <a90cc3e15a94274bb22b990be16cd1f62747a0dd.1288714384.git.jeremy.fitzhardinge@citrix.com>
> info->gd->disk_name);
> error = -EOPNOTSUPP;
> + }
> + if (unlikely(bret->status == BLKIF_RSP_ERROR &&
> + info->shadow[id].req.nr_segments == 0)) {
> + printk(KERN_WARNING "blkfront: %s: empty write barrier op failed\n",
> + info->gd->disk_name);
> + error = -EOPNOTSUPP;
> + }
We don't use -EOPNOTSUPP anymore in the new world order, anything
barrier related is just a normal I/O error now.
prev parent reply other threads:[~2010-11-02 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-02 16:20 [PATCH 0/4] FLUSH/FUA updates for Xen blkfront Jeremy Fitzhardinge
2010-11-02 16:20 ` Jeremy Fitzhardinge
2010-11-02 16:20 ` [PATCH 1/4] xen/blkfront: map REQ_FLUSH into a full barrier Jeremy Fitzhardinge
2010-11-02 16:20 ` [PATCH 2/4] xen/blkfront: change blk_shadow.request to proper pointer Jeremy Fitzhardinge
2010-11-02 16:20 ` [PATCH 3/4] xen/blkfront: Implement FUA with BLKIF_OP_WRITE_BARRIER Jeremy Fitzhardinge
2010-11-02 16:20 ` [PATCH 4/4] xen/blkfront: cope with backend that fail empty BLKIF_OP_WRITE_BARRIER requests Jeremy Fitzhardinge
2010-11-02 16:54 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101102165434.GA19703@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=daniel.stodden@citrix.com \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.