From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH] building fix - do not check unsigned var >= 0 Date: Tue, 2 Nov 2010 20:58:39 +0200 Message-ID: <20101102185839.GA2744@redhat.com> References: <201010131032.18942.ruirui.r.yang@tieto.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: kvm@vger.kernel.org To: Yang Ruirui Return-path: Received: from mx1.redhat.com ([209.132.183.28]:60355 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753379Ab0KBS6l (ORCPT ); Tue, 2 Nov 2010 14:58:41 -0400 Content-Disposition: inline In-Reply-To: <201010131032.18942.ruirui.r.yang@tieto.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Oct 13, 2010 at 10:32:18AM +0800, Yang Ruirui wrote: > fix following build error by do not check unsigned op >=3D 0:=20 >=20 > CC x86_64-softmmu/tcg/tcg.o > cc1: warnings being treated as errors > /home/dave/git/qemu-kvm/tcg/tcg.c: In function =E2=80=98tcg_add_targe= t_add_op_defs=E2=80=99: > /home/dave/git/qemu-kvm/tcg/tcg.c:1030: error: comparison of unsigned= expression >=3D 0 is always true > make[1]: *** [tcg/tcg.o] Error 1 >=20 > Signed-off-by: Yang Ruirui > Signed-off-by: Dave Young I think Blue Swirl was replacing these with range macros from range.h > --- > tcg/tcg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > --- qemu-kvm.orig/tcg/tcg.c 2010-06-29 14:45:04.000000000 +0800 > +++ qemu-kvm/tcg/tcg.c 2010-09-26 18:07:26.523339798 +0800 > @@ -1027,7 +1027,7 @@ void tcg_add_target_add_op_defs(const TC > if (tdefs->op =3D=3D (TCGOpcode)-1) > break; > op =3D tdefs->op; > - assert(op >=3D 0 && op < NB_OPS); > + assert(op < NB_OPS); > def =3D &tcg_op_defs[op]; > #if defined(CONFIG_DEBUG_TCG) > /* Duplicate entry in op definitions? */ > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html