From: Marcelo Tosatti <mtosatti@redhat.com>
To: Tim Pepper <lnxninja@linux.vnet.ibm.com>
Cc: kvm@vger.kernel.org
Subject: Re: extraneous allocation in qemu-kvm's hw/pc_piix.c
Date: Wed, 3 Nov 2010 10:56:11 -0200 [thread overview]
Message-ID: <20101103125611.GC16809@amt.cnet> (raw)
In-Reply-To: <AANLkTi=9KqHFLJKBR+VoK3CLDRN1gheJJYJZ6crvnryf@mail.gmail.com>
On Tue, Oct 26, 2010 at 10:52:00AM -0700, Tim Pepper wrote:
> While doing some source review I noticed what appears to be
> an extraneous call to pc_allocate_cpu_irq() in qemu-kvm and
> which does not appear in qemu. From the git history it almost
> looks like b725a661eb38c93086e0b98f626a3864ae8651b8 mis-merged
> 845773ab03a8dde681ff1b929bbb41e67d0131a6? At any rate qemu-kvm got
> patched differently than qemu for the piix split out and this line
> appears to allocate something which then goes unused.
>
> Signed-off-by: Tim Pepper <lnxninja@linux.vnet.ibm.com>
Applied, thanks.
next prev parent reply other threads:[~2010-11-03 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-26 17:52 extraneous allocation in qemu-kvm's hw/pc_piix.c Tim Pepper
2010-10-27 18:34 ` Tim Pepper
2010-11-03 12:56 ` Marcelo Tosatti [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-10-25 17:15 Tim Pepper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101103125611.GC16809@amt.cnet \
--to=mtosatti@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lnxninja@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.