Re: [PATCH 08/16] xenpaging: reduce MINIMUM_RESTART_TIME

[Olaf Hering <olaf@aepfle.de>]

On Wed, Nov 03, Ian Jackson wrote:

> Olaf Hering writes ("[Xen-devel] [PATCH 08/16] xenpaging: reduce MINIMUM_RESTART_TIME"):
> > Allow runlevel 6 as default runlevel.
> ...
> > -MINIMUM_RESTART_TIME = 60
> > +MINIMUM_RESTART_TIME = 5
> 
> I don't understand what this change is doing in your xenpaging series;
> nor does setting runlevel 6 as the default runlevel seem very
> sensible other than perhaps for some kind of stress testing.
> 
> Perhaps this patch snuck into the series by mistake ?

Its there intentional in my series, just to get the startup code tested
automatically. The runtime code seems to work ok now that the granttable
part got fixed.

Last time I tried to get this variable into the vm config file, it did
not work as expected. Appearently its a global variable, not per guest.


And its value was changed from 20 (I think) to 60 without a good
changelog entry, not too long ago. For my testing, even 20 would have
been to long. If I use 'reboot' quickly in grub, guest runtime is around
7 seconds I think.


Too bad, this variable is only a bandaid because it doesnt know any
context of the guest. And it cant know any context. When is a guest in a
good or bad state? Should it panic, or crash? Its not easy to detect
a bad condition.

A better change would be to allow an override in the guest config file.


Olaf