From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Repair initramfs dependancies after move to fs
Date: Thu, 4 Nov 2010 17:16:59 +0100 [thread overview]
Message-ID: <20101104171659.3aaa4f94@surf> (raw)
In-Reply-To: <1271687689-344-1-git-send-email-will_wagner@carallon.com>
Hello Will,
I'm replying on this old patch that I acked back in April. But I now
have one question. While I still agree on the changes on
target/linux/Makefile* (now linux/linux.mk), I don't understand why the
following change was needed:
> diff --git a/fs/initramfs/initramfs.mk b/fs/initramfs/initramfs.mk
> index 4a205d1..9aaf1b0 100644
> --- a/fs/initramfs/initramfs.mk
> +++ b/fs/initramfs/initramfs.mk
> @@ -6,6 +6,12 @@
> #
> #############################################################
>
> +ifeq ($(BR2_TARGET_ROOTFS_INITRAMFS),y)
> +INITRAMFS_TARGET:=initramfs-root
> +else
> +INITRAMFS_TARGET:= #nothing
> +endif
the INITRAMFS_TARGET variable isn't used anywhere in the current git.
Isn't this code useless ? (I think it is, but I'd like to be sure).
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2010-11-04 16:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-19 14:34 [Buildroot] [PATCH] Repair initramfs dependancies after move to fs Will Wagner
2010-04-19 21:07 ` Thomas Petazzoni
2010-04-19 22:03 ` Peter Korsgaard
2010-11-04 16:16 ` Thomas Petazzoni [this message]
2010-11-04 16:51 ` William Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101104171659.3aaa4f94@surf \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.