From: Tony Lindgren <tony@atomide.com>
To: Nishanth Menon <nm@ti.com>
Cc: l-o <linux-omap@vger.kernel.org>, Kevin H <khilman@deeprootsystems.com>
Subject: Re: [PATCH 2/3 v2] omap4: opp: add OPP table data
Date: Thu, 4 Nov 2010 16:13:09 -0700 [thread overview]
Message-ID: <20101104231309.GE9264@atomide.com> (raw)
In-Reply-To: <1287536543-9729-3-git-send-email-nm@ti.com>
* Nishanth Menon <nm@ti.com> [101019 17:53]:
> @@ -86,7 +87,10 @@ int __init omap_init_opp_table(void)
> omap_table_init = 1;
>
> /* Select the OPP table we'd like to enable based on cpu we are on */
> - if (cpu_is_omap34xx()) {
> + if (cpu_is_omap44xx()) {
> + opp_def = omap44xx_opp_def_list;
> + opp_def_size = ARRAY_SIZE(omap44xx_opp_def_list);
> + } else if (cpu_is_omap34xx()) {
> opp_def = cpu_is_omap3630() ? omap36xx_opp_def_list :
> omap34xx_opp_def_list;
> opp_def_size = cpu_is_omap3630() ?
And based on the comments in patch 1/3, when you add support for
new processor, you just add a new init function instead of adding
"if cpu_is_omapxxxx else if" chunks.
Regards,
Tony
next prev parent reply other threads:[~2010-11-04 23:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 1:02 [PATCH 0/3 v2] omap: opp: Add opp data Nishanth Menon
2010-10-20 1:02 ` [PATCH 1/3 v2] omap: opp: add OMAP3 OPP table data and common init Nishanth Menon
2010-10-20 1:02 ` [PATCH 2/3 v2] omap4: opp: add OPP table data Nishanth Menon
2010-10-20 1:02 ` [PATCH 3/3 v2] OMAP3: remove OPP interfaces from OMAP PM layer Nishanth Menon
2010-11-04 23:20 ` Tony Lindgren
2010-11-04 23:13 ` Tony Lindgren [this message]
2010-11-05 0:05 ` [PATCH 2/3 v2] omap4: opp: add OPP table data Menon, Nishanth
2010-11-04 23:10 ` [PATCH 1/3 v2] omap: opp: add OMAP3 OPP table data and common init Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101104231309.GE9264@atomide.com \
--to=tony@atomide.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.