diff for duplicates of <20101105023525.GC28308@ericsson.com> diff --git a/a/1.txt b/N1/1.txt index 362171f..b28ebbd 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -25,19 +25,14 @@ On Sun, Oct 31, 2010 at 03:50:30AM -0400, Henrik Rydberg wrote: > > - temp = buffer[0]*1000; > - temp += (buffer[1] >> 6) * 250; -> + if (entry.len = 2) { +> + if (entry.len == 2) { > + temp = buffer[0]*1000; > + temp += (buffer[1] >> 6) * 250; > + } else { > + temp = buffer[0] * 4000; > + } -Another comment - in the next patch, you check for entry.len = 0. +Another comment - in the next patch, you check for entry.len == 0. If that can happen, you would need to check it here as well. Guenter - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index 9edb4de..1673bb6 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,8 +1,8 @@ "ref\01288511434-5662-1-git-send-email-rydberg@euromail.se\0" "ref\01288511434-5662-5-git-send-email-rydberg@euromail.se\0" "From\0Guenter Roeck <guenter.roeck@ericsson.com>\0" - "Subject\0Re: [lm-sensors] [PATCH 4/8] hwmon: applesmc: Handle new\0" - "Date\0Fri, 05 Nov 2010 02:35:25 +0000\0" + "Subject\0Re: [lm-sensors] [PATCH 4/8] hwmon: applesmc: Handle new temperature format\0" + "Date\0Thu, 4 Nov 2010 19:35:25 -0700\0" "To\0Henrik Rydberg <rydberg@euromail.se>\0" "Cc\0Jean Delvare <khali@linux-fr.org>" linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org> @@ -36,21 +36,16 @@ "> \n" "> -\ttemp = buffer[0]*1000;\n" "> -\ttemp += (buffer[1] >> 6) * 250;\n" - "> +\tif (entry.len = 2) {\n" + "> +\tif (entry.len == 2) {\n" "> +\t\ttemp = buffer[0]*1000;\n" "> +\t\ttemp += (buffer[1] >> 6) * 250;\n" "> +\t} else {\n" "> +\t\ttemp = buffer[0] * 4000;\n" "> +\t}\n" "\n" - "Another comment - in the next patch, you check for entry.len = 0.\n" + "Another comment - in the next patch, you check for entry.len == 0.\n" "If that can happen, you would need to check it here as well.\n" "\n" - "Guenter\n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + Guenter -5d67ac6b04321a3da0549e279059d3663ccad914c0e2bd58e5f2d58d64f74656 +47109fd7ab88d89c7218043059a5a6124f6f2b98e839e4e9f66a9c65e3a22e2c
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.