Re: [PATCH 1/7] ASoC: i.MX31ads: initialize only on correct machine

[Sascha Hauer <s.hauer@pengutronix.de>]

On Thu, Nov 04, 2010 at 02:51:36PM -0400, Mark Brown wrote:
> On Thu, Nov 04, 2010 at 05:05:39PM +0100, Sascha Hauer wrote:
> 
> > +	if (!machine_is_mx31ads())
> > +		return 0;
> > +
> 
> As previously discussed we need a better check than this - most of these
> machines won't have a 1133-EV1 PMIC module on them.  Better to convert
> the driver to instantiate from a platform device...

This does not solve the problem as we do not know when to register the
platform_device. I think what we need is a kernel parameter which can be
used to select the correct path in arch/arm/mach-mx3/mach-mx31ads.c
aswell. I will look into it. For now, can we just take this patch? It
at least fixes all other i.MX31 boards and leaves only the mx31ads to
work on.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |