From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sheng Yang <sheng@linux.intel.com>
Subject: Re: [PATCH 1/3] qemu-kvm: Ioctl for in-kernel mask support
Date: Fri, 5 Nov 2010 10:59:23 +0800
Message-ID: <201011051059.23872.sheng@linux.intel.com>
References: <1288851501-4180-1-git-send-email-sheng@linux.intel.com> <1288851501-4180-2-git-send-email-sheng@linux.intel.com> <20101104094758.GD27506@redhat.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org
To: "Michael S. Tsirkin" <mst@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mga11.intel.com ([192.55.52.93]:40928 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752670Ab0KEC7L (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 4 Nov 2010 22:59:11 -0400
In-Reply-To: <20101104094758.GD27506@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thursday 04 November 2010 17:47:58 Michael S. Tsirkin wrote:
> On Thu, Nov 04, 2010 at 02:18:19PM +0800, Sheng Yang wrote:
> > Signed-off-by: Sheng Yang <sheng@linux.intel.com>
> > ---
> > 
> >  qemu-kvm.c |   15 +++++++++++++++
> >  qemu-kvm.h |    6 ++++++
> >  2 files changed, 21 insertions(+), 0 deletions(-)
> > 
> > diff --git a/qemu-kvm.c b/qemu-kvm.c
> > index 733d0a9..ba6db51 100644
> > --- a/qemu-kvm.c
> > +++ b/qemu-kvm.c
> > @@ -1092,6 +1092,21 @@ int kvm_assign_set_msix_entry(kvm_context_t kvm,
> > 
> >  {
> >  
> >      return kvm_vm_ioctl(kvm_state, KVM_ASSIGN_SET_MSIX_ENTRY, entry);
> >  
> >  }
> > 
> > +
> > +#ifdef KVM_CAP_DEVICE_MSIX_MASK
> > +int kvm_assign_get_msix_entry(kvm_context_t kvm,
> > +                              struct kvm_assigned_msix_entry *entry)
> > +{
> > +    return kvm_vm_ioctl(kvm_state, KVM_ASSIGN_GET_MSIX_ENTRY, entry);
> > +}
> > +
> > +int kvm_assign_reg_msix_mmio(kvm_context_t kvm,
> > +                           struct kvm_assigned_msix_mmio *msix_mmio)
> > +{
> > +    return kvm_vm_ioctl(kvm_state, KVM_ASSIGN_REG_MSIX_MMIO, msix_mmio);
> > +}
> > +#endif
> > +
> > 
> >  #endif
> >  
> >  #if defined(KVM_CAP_IRQFD) && defined(CONFIG_EVENTFD)
> > 
> > diff --git a/qemu-kvm.h b/qemu-kvm.h
> > index 9c08ab4..1afdd42 100644
> > --- a/qemu-kvm.h
> > +++ b/qemu-kvm.h
> > @@ -743,6 +743,12 @@ int kvm_assign_set_msix_nr(kvm_context_t kvm,
> > 
> >                             struct kvm_assigned_msix_nr *msix_nr);
> >  
> >  int kvm_assign_set_msix_entry(kvm_context_t kvm,
> >  
> >                                struct kvm_assigned_msix_entry *entry);
> > 
> > +#ifdef KVM_CAP_DEVICE_MSIX_MASK
> > +int kvm_assign_get_msix_entry(kvm_context_t kvm,
> > +                              struct kvm_assigned_msix_entry *entry);
> > +int kvm_assign_reg_msix_mmio(kvm_context_t kvm,
> > +                           struct kvm_assigned_msix_mmio *msix_mmio);
> > +#endif
> > 
> >  #endif
> >  
> >  #else                           /* !CONFIG_KVM */
> 
> We are trying to move away from using ifdefs. Stub these out instead?

Example?

--
regards
Yang, Sheng