Re: [PATCH 7/7] Bluetooth: Fix not returning proper error in RFCOMM

[Ville Tervo <ville.tervo@nokia.com>]

Hi Gustavo,

On Tue, Nov 02, 2010 at 04:03:18PM +0100, ext Gustavo F. Padovan wrote:
> Return 0 in that situation could lead to errors in the caller.
> 
> Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
> ---
>  net/bluetooth/rfcomm/sock.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/bluetooth/rfcomm/sock.c b/net/bluetooth/rfcomm/sock.c
> index e48fbca..cd7e27a 100644
> --- a/net/bluetooth/rfcomm/sock.c
> +++ b/net/bluetooth/rfcomm/sock.c
> @@ -930,7 +930,7 @@ int rfcomm_connect_ind(struct rfcomm_session *s, u8 channel, struct rfcomm_dlc *
>  	/* Check if we have socket listening on channel */
>  	parent = rfcomm_get_sock_by_channel(BT_LISTEN, channel, &src);
>  	if (!parent)
> -		return 0;
> +		return -EINVAL;

Did you check rfcomm/core.c?

I think this change breaks the logic in there. IOW continues connection
establisment instead of tearing down the link.

-- 
Ville