From: Greg KH <greg@kroah.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: Ionut Nicu <ionut.nicu@gmail.com>,
Omar Ramirez Luna <omar.ramirez@ti.com>,
Fernando Guzman Lugo <x0095840@ti.com>,
linux-omap <linux-omap@vger.kernel.org>,
Ionut Nicu <ionut.nicu@mindbit.ro>
Subject: Re: [PATCH v2 1/3] staging: tidspbridge: fix mgr_enum_node_info
Date: Fri, 5 Nov 2010 09:09:04 -0700 [thread overview]
Message-ID: <20101105160904.GA28784@kroah.com> (raw)
In-Reply-To: <AANLkTimgHvTz9sSG+opnnkeGQ2LH7hVV5x-iJOMvffgE@mail.gmail.com>
On Fri, Nov 05, 2010 at 06:01:47PM +0200, Felipe Contreras wrote:
> On Fri, Nov 5, 2010 at 5:15 PM, Ionut Nicu <ionut.nicu@gmail.com> wrote:
> > The current code was always returning a non-zero status value
> > to userspace applications when this ioctl was called.
> >
> > The error code was ENODATA, which isn't actually an error,
> > it's always returned by dcd_enumerate_object() when it hits the
> > end of list.
> >
> > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> > Signed-off-by: Ionut Nicu <ionut.nicu@mindbit.ro>
>
> You should leave the original author (me).
Ick, yes, that is very bad.
Ionut, please go re-read Documentation/SubmittingPatches for how to
properly attribute the original author of the patch. Please resend all
of these patches after ensuring that you have the proper authors
credited.
thanks,
greg k-h
next prev parent reply other threads:[~2010-11-05 16:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 15:15 [PATCH v2 0/3] staging: tidspbridge: bugfixes Ionut Nicu
2010-11-05 15:15 ` [PATCH v2 1/3] staging: tidspbridge: fix mgr_enum_node_info Ionut Nicu
2010-11-05 16:01 ` Felipe Contreras
2010-11-05 16:09 ` Greg KH [this message]
2010-11-05 16:17 ` Ionut Nicu
2010-11-05 16:24 ` Greg KH
2010-11-05 15:15 ` [PATCH v2 2/3] staging: tidspbridge: mgr_enum_node_info cleanup Ionut Nicu
2010-11-05 15:15 ` [PATCH v2 3/3] staging: tidspbridge: fix kernel oops in bridge_io_get_proc_load Ionut Nicu
2010-11-05 15:43 ` [PATCH v2 0/3] staging: tidspbridge: bugfixes Greg KH
2010-11-05 16:00 ` Ionut Nicu
2010-11-05 17:54 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101105160904.GA28784@kroah.com \
--to=greg@kroah.com \
--cc=felipe.contreras@gmail.com \
--cc=ionut.nicu@gmail.com \
--cc=ionut.nicu@mindbit.ro \
--cc=linux-omap@vger.kernel.org \
--cc=omar.ramirez@ti.com \
--cc=x0095840@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.