From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <balbi@ti.com>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 3/4] cbus: tahvo: move platform_device to board file
Date: Fri, 5 Nov 2010 09:36:02 -0700 [thread overview]
Message-ID: <20101105163602.GJ9264@atomide.com> (raw)
In-Reply-To: <20101001123737.GT2925@legolas.emea.dhcp.ti.com>
* Felipe Balbi <balbi@ti.com> [101001 05:29]:
> On Fri, Oct 01, 2010 at 07:33:38AM -0500, Balbi, Felipe wrote:
> >@@ -255,9 +269,24 @@ static void __init n8x0_cbus_init(void)
> > return;
> > }
> >
> >- set_irq_type(gpio_to_irq(108), IRQ_TYPE_EDGE_RISING);
> >- retu_resource[0].start = gpio_to_irq(108);
> >- platform_device_register(&retu_device);
>
> hmmm, these three deleted lines look suspicious :-(
>
> Let these cook for a while, I'll get back to them in a day or two. CBUS
> is making me crazy :-p
Marking these as changes needed then in pw.k.o.
Tony
next prev parent reply other threads:[~2010-11-05 16:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-01 12:33 [PATCH 0/4] CBUS patches (v2) Felipe Balbi
2010-10-01 12:33 ` [PATCH 1/4] cbus: remove unneded includes Felipe Balbi
2010-10-01 12:33 ` [PATCH 2/4] cbus: retu: move platform_device to board file Felipe Balbi
2010-10-01 12:33 ` [PATCH 3/4] cbus: tahvo: " Felipe Balbi
2010-10-01 12:37 ` Felipe Balbi
2010-11-05 16:36 ` Tony Lindgren [this message]
2010-11-05 16:40 ` Tony Lindgren
2010-10-01 12:33 ` [PATCH 4/4] cbus: tahvo-usb: " Felipe Balbi
-- strict thread matches above, loose matches on Subject: below --
2010-10-19 7:29 [PATCH 0/4] Horray, more CBUS patches Felipe Balbi
2010-10-19 7:29 ` [PATCH 3/4] cbus: tahvo: move platform_device to board file Felipe Balbi
2010-10-01 7:47 [PATCH 0/4] CBUS patches Felipe Balbi
2010-10-01 7:47 ` [PATCH 3/4] cbus: tahvo: move platform_device to board file Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101105163602.GJ9264@atomide.com \
--to=tony@atomide.com \
--cc=balbi@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.