All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Mathias Nyman <mathias.nyman@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] omap: dma: Add read-back to DMA interrupt handler to avoid spurious interrupts
Date: Fri, 5 Nov 2010 09:51:02 -0700	[thread overview]
Message-ID: <20101105165102.GN9264@atomide.com> (raw)
In-Reply-To: <1288017324-2181-1-git-send-email-mathias.nyman@nokia.com>

* Mathias Nyman <mathias.nyman@nokia.com> [101025 07:22]:
> Flush the writes to IRQSTATUS_L0 register in the DMA interrupt handler by reading the register
> directly after write. This prevents the spurious DMA interrupts noted when using VDD_OPP 1

Adding this to omap-fixes. For future arch/arm/*omap*/ patches,
please always Cc also linux-arm-kernel list. That way I can
apply the patch without a need to repost.

Regards,

Tony
 
> Signed-off-by: Mathias Nyman <mathias.nyman@nokia.com>
> ---
>  arch/arm/plat-omap/dma.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
> index f5c5b8d..2c28265 100644
> --- a/arch/arm/plat-omap/dma.c
> +++ b/arch/arm/plat-omap/dma.c
> @@ -1983,6 +1983,8 @@ static int omap2_dma_handle_ch(int ch)
>  
>  	dma_write(OMAP2_DMA_CSR_CLEAR_MASK, CSR(ch));
>  	dma_write(1 << ch, IRQSTATUS_L0);
> +	/* read back the register to flush the write */
> +	dma_read(IRQSTATUS_L0);
>  
>  	/* If the ch is not chained then chain_id will be -1 */
>  	if (dma_chan[ch].chain_id != -1) {
> -- 
> 1.5.6.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2010-11-05 16:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-25 14:35 [PATCH] omap: dma: Add read-back to DMA interrupt handler to avoid spurious interrupts Mathias Nyman
2010-10-26  5:31 ` Shilimkar, Santosh
2010-11-05 16:51 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101105165102.GN9264@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=mathias.nyman@nokia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.