From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 5/5] KVM: assigned dev: MSI-X mask support Date: Fri, 5 Nov 2010 22:24:51 -0200 Message-ID: <20101106002451.GA410@amt.cnet> References: <1288851321-3964-1-git-send-email-sheng@linux.intel.com> <201011051044.19224.sheng@linux.intel.com> <20101105084333.GA3464@redhat.com> <201011051853.51093.sheng@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Michael S. Tsirkin" , Avi Kivity , kvm@vger.kernel.org To: Sheng Yang Return-path: Received: from mx1.redhat.com ([209.132.183.28]:22880 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753710Ab0KFA2W (ORCPT ); Fri, 5 Nov 2010 20:28:22 -0400 Content-Disposition: inline In-Reply-To: <201011051853.51093.sheng@linux.intel.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Nov 05, 2010 at 06:53:50PM +0800, Sheng Yang wrote: > On Friday 05 November 2010 16:43:33 Michael S. Tsirkin wrote: > > On Fri, Nov 05, 2010 at 10:44:19AM +0800, Sheng Yang wrote: > > > > > +}; > > > > > + > > > > > +This ioctl would enable in-kernel MSI-X emulation, which would > > > > > handle MSI-X +mask bit in the kernel. > > > > > > > > What happens on repeated calls when it's already enabled? > > > > How does one disable after it's enabled? > > > > > > Suppose this should only be called once. But again would update the MMIO > > > base. > > > > So maybe add this all to documentation. > > > > > It > > > would be disabled along with device deassignment. > > > > So what are you going to do when guest enables and later disables MSIX? > > Disable assignment completely? > > This device goes with PCI resources allocation, rather than IRQ assignment. What about hot plug, for example? I can't see how this can function without unregistering regions.