From: "Américo Wang" <xiyou.wangcong@gmail.com>
To: Anders Kaseorg <andersk@ksplice.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
linux-kernel@vger.kernel.org, Tim Abbott <tabbott@ksplice.com>
Subject: Re: [PATCH] module: Update prototype for ref_module (formerly use_module)
Date: Sun, 7 Nov 2010 16:06:48 +0800 [thread overview]
Message-ID: <20101107080648.GN3046@hack> (raw)
In-Reply-To: <alpine.DEB.2.00.1011051702090.3947@dr-wily.mit.edu>
On Fri, Nov 05, 2010 at 05:05:46PM -0400, Anders Kaseorg wrote:
>Commit 9bea7f23952d5948f8e5dfdff4de09bb9981fb5f renamed use_module to
>ref_module (and changed its return value), but forgot to update this
>prototype in module.h.
>
>Signed-off-by: Anders Kaseorg <andersk@ksplice.com>
Acked-by: WANG Cong <xiyou.wangcong@gmail.com>
I am wondering why we find this after 5 months! :-/
>---
> include/linux/module.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/include/linux/module.h b/include/linux/module.h
>index aace066..caf6105 100644
>--- a/include/linux/module.h
>+++ b/include/linux/module.h
>@@ -514,7 +514,7 @@ static inline void __module_get(struct module *module)
> #define symbol_put_addr(p) do { } while(0)
>
> #endif /* CONFIG_MODULE_UNLOAD */
>-int use_module(struct module *a, struct module *b);
>+int ref_module(struct module *a, struct module *b);
>
> /* This is a #define so the string doesn't get put in every .o file */
> #define module_name(mod) \
>--
>1.7.3.1
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
--
Live like a child, think like the god.
next prev parent reply other threads:[~2010-11-07 8:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 21:05 [PATCH] module: Update prototype for ref_module (formerly use_module) Anders Kaseorg
2010-11-07 8:06 ` Américo Wang [this message]
2010-11-08 7:18 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101107080648.GN3046@hack \
--to=xiyou.wangcong@gmail.com \
--cc=andersk@ksplice.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tabbott@ksplice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.