All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@amd64.org>
To: Tracey Dent <tdent48227@gmail.com>
Cc: "mchehab@redhat.com" <mchehab@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Drivers: edac: Makfile: Cleaned up Makefile
Date: Sun, 7 Nov 2010 11:29:02 +0100	[thread overview]
Message-ID: <20101107102902.GA7230@aftab> (raw)
In-Reply-To: <1289070307-2563-1-git-send-email-tdent48227@gmail.com>

On Sat, Nov 06, 2010 at 03:05:07PM -0400, Tracey Dent wrote:
> Changed Makefile to use <modules>-y instead of <modules>-objs.
> 
> Signed-off-by: Tracey Dent <tdent48227@gmail.com>

While I don't object the change, I think your commit message should be
fixed not to say _what_ your patch changes (we can see that) but to say
_why_ you're making that change. See, I had to go search lkml just to
find why all of a sudden <..>-objs is being changed.

So please go and add text explaining that -objs is deprecated and so on.
And make sure you've checked out Documentation/SubmittingPatches - it'll
save you a lot of trouble in the future :).

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

  reply	other threads:[~2010-11-07 10:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-06 19:05 [PATCH] Drivers: edac: Makfile: Cleaned up Makefile Tracey Dent
2010-11-07 10:29 ` Borislav Petkov [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-11-07 14:43 Tracey Dent
2010-11-11 14:09 ` Borislav Petkov
2010-11-11 15:47   ` Tracey Dent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101107102902.GA7230@aftab \
    --to=bp@amd64.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@redhat.com \
    --cc=tdent48227@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.