From: Matthew Wilcox <willy@linux.intel.com>
To: Luben Tuikov <ltuikov@yahoo.com>
Cc: Greg KH <greg@kroah.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] [USB] UAS: Use kzalloc instead of kmalloc
Date: Mon, 8 Nov 2010 06:21:31 -0500 [thread overview]
Message-ID: <20101108112131.GG4173@linux.intel.com> (raw)
In-Reply-To: <628096.54960.qm@web31807.mail.mud.yahoo.com>
On Wed, Oct 27, 2010 at 01:22:22PM -0700, Luben Tuikov wrote:
> "Be conservative in what you send, liberal in what
> you accept." -- In the spirit of this adage, don't
> send Command IUs with randomly filled in data in
> the reserved fields. (Yes, this shows up on the
> wire.)
Applied, with a better changelog entry ...
> @@ -660,7 +660,7 @@ static int uas_probe(struct usb_interface *intf, const struct usb_device_id *id)
> return -ENODEV;
> }
>
> - devinfo = kmalloc(sizeof(struct uas_dev_info), GFP_KERNEL);
> + devinfo = kzalloc(sizeof(struct uas_dev_info), GFP_KERNEL);
> if (!devinfo)
> return -ENOMEM;
>
Except for this hunk, which isn't an IU and doesn't go out on the wire.
next prev parent reply other threads:[~2010-11-08 11:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 20:22 [PATCH] [USB] UAS: Use kzalloc instead of kmalloc Luben Tuikov
2010-10-27 20:22 ` Luben Tuikov
2010-11-08 11:21 ` Matthew Wilcox [this message]
2010-11-08 15:55 ` Greg KH
2010-11-08 16:59 ` Luben Tuikov
2010-11-08 16:59 ` Luben Tuikov
-- strict thread matches above, loose matches on Subject: below --
2010-11-08 17:50 Luben Tuikov
2010-11-08 17:50 ` Luben Tuikov
2010-11-08 18:46 Luben Tuikov
2010-11-08 18:46 ` Luben Tuikov
2010-12-10 10:49 Luben Tuikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101108112131.GG4173@linux.intel.com \
--to=willy@linux.intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ltuikov@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.