All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann Dirson <dirson@bertin.fr>
To: Kevin Ballard <kevin@sb.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCHv3 1/2] rebase: better rearranging of fixup!/squash! lines with --autosquash
Date: Mon, 08 Nov 2010 11:52:39 +0100	[thread overview]
Message-ID: <20101108115239.7309504f@chalon.bertin.fr> (raw)
In-Reply-To: <1289213283-24294-1-git-send-email-kevin@sb.org>

Kevin wrote:
>The current behvaior of --autosquash can duplicate fixup!/squash! lines
>if they match multiple commits, and it can also apply them to commits
>that come after them in the todo list.

That last part of the sentence does not match my experience - it looks
like you describe as a bug a nonexistent feature I miss :)

See http://marc.info/?l=git&m=128784082701920 for a testcase that
exhibits what I think is a problem.

-- 
Yann Dirson - Bertin Technologies

  reply	other threads:[~2010-11-08 11:03 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-04  2:41 [PATCH 1/2] rebase: better rearranging of fixup!/squash! lines with --autosquash Kevin Ballard
2010-11-04  2:41 ` [PATCH 2/2] rebase: teach --autosquash to match on sha1 in addition to message Kevin Ballard
2010-11-04  4:49   ` Kevin Ballard
2010-11-04 10:44     ` Sverre Rabbelier
2010-11-04 21:35       ` Kevin Ballard
2010-11-04 19:09     ` Junio C Hamano
2010-11-04 22:36       ` [PATCHv2 1/2] rebase: better rearranging of fixup!/squash! lines with --autosquash Kevin Ballard
2010-11-04 22:36       ` [PATCHv2 2/2] rebase: teach --autosquash to match on sha1 in addition to message Kevin Ballard
2010-11-05 13:04   ` [PATCH " Peter Krefting
2010-11-08 10:48     ` [PATCHv3 1/2] rebase: better rearranging of fixup!/squash! lines with --autosquash Kevin Ballard
2010-11-08 10:52       ` Yann Dirson [this message]
2010-11-08 11:10         ` Kevin Ballard
2010-11-08 10:48     ` [PATCHv3 2/2] rebase: teach --autosquash to match on sha1 in addition to message Kevin Ballard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101108115239.7309504f@chalon.bertin.fr \
    --to=dirson@bertin.fr \
    --cc=git@vger.kernel.org \
    --cc=kevin@sb.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.