From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCHv2 7/8] Change pci bus get_dev_path callback to print only slot and func Date: Mon, 8 Nov 2010 23:12:02 +0200 Message-ID: <20101108211202.GF19863@redhat.com> References: <1288525209-3303-1-git-send-email-gleb@redhat.com> <1288525209-3303-8-git-send-email-gleb@redhat.com> <20101108171737.GA8498@redhat.com> <20101108172950.GB19863@redhat.com> <20101108210017.GC10777@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, blauwirbel@gmail.com, armbru@redhat.com, alex.williamson@redhat.com To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:2582 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754502Ab0KHVMG (ORCPT ); Mon, 8 Nov 2010 16:12:06 -0500 Content-Disposition: inline In-Reply-To: <20101108210017.GC10777@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Nov 08, 2010 at 11:00:17PM +0200, Michael S. Tsirkin wrote: > On Mon, Nov 08, 2010 at 07:29:50PM +0200, Gleb Natapov wrote: > > > This will make it compatible with existing code and generally > > > what users expect. > > > > > It will drop domain and bus number part anyway. > > Yes but the proposal was to add 0000:00: in front to > make it have the expected format for most users. > I am not interesting in hacks. I do not know who are those most users you are talking about and why they expect 0000:00: in front of something. Anyway, as I said, I moved to use another callback so you can do whatever you want with get_dev_path. -- Gleb.